search

NibiruChain / nibiru

Nibiru Chain: The breakthrough smart contract platform ushering in the next era of money. Nibiru powers an ecosystem of dApps including perps, RWAs, and more.
https://nibiru.fi
Apache License 2.0
182 stars 200 forks source link

chore(test): reverted funtoken precompile test back to the isolated state #1961

Closed onikonychev closed 1 month ago

onikonychev commented 1 month ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

[!WARNING]

Review failed

The pull request is closed.

Walkthrough

The updates primarily streamline functionality and improve clarity in the code regarding validator node logging and FunToken handling. Specifically, redundant wording in a log message within the stopValidatorNode function was removed, and substantial changes were made to the logic for creating and managing FunTokens, including a new function for creating tokens based on bank coins.

Changes

File Change Summary
x/common/testutil/testnetwork/validator_node.go Simplified error log message in stopValidatorNode function by removing a redundant word.
x/evm/precompile/funtoken_test.go Introduced CreateFunTokenForBankCoin function, restructured token creation and transfer processes, adjusted balance checks, and improved account transfers.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Validator
    participant Logger

    User->>Validator: stopValidatorNode()
    Validator->>Logger: Logf("❌ Error closing the API server: %w", err)
    Logger-->>Validator: Log entry created
sequenceDiagram
    participant TestDeps
    participant Suite
    participant FunToken

    TestDeps->>Suite: CreateFunTokenForBankCoin(bankDenom)
    Suite->>FunToken: Initialize and Return FunToken
    FunToken-->>Suite: FunToken created for bank coin

Poem

In lines of code, improvements flow, Errors trimmed for logs to show. FunTokens crafted with precision, Balance checks in clear vision. Code refined, more robust, In Rabbit's realm, in code we trust. 🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.64%. Comparing base (d24f7a1) to head (a31ca79).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1961 +/- ## ========================================== - Coverage 65.65% 65.64% -0.02% ========================================== Files 257 257 Lines 16433 16434 +1 ========================================== - Hits 10789 10788 -1 - Misses 4840 4841 +1 - Partials 804 805 +1 ``` | [Files](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1961?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain) | Coverage Δ | | |---|---|---| | [x/common/testutil/testnetwork/validator\_node.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1961?src=pr&el=tree&filepath=x%2Fcommon%2Ftestutil%2Ftestnetwork%2Fvalidator_node.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9jb21tb24vdGVzdHV0aWwvdGVzdG5ldHdvcmsvdmFsaWRhdG9yX25vZGUuZ28=) | `77.61% <0.00%> (-2.70%)` | :arrow_down: |