search

NibiruChain / nibiru

Nibiru Chain: The breakthrough smart contract platform ushering in the next era of money. Nibiru powers an ecosystem of dApps including perps, RWAs, and more.
https://nibiru.fi
Apache License 2.0
183 stars 201 forks source link

refactor(evm): funtoken events, cli commands and queries #1968

Closed onikonychev closed 2 months ago

onikonychev commented 3 months ago
  1. Emitting event EventFunTokenCreated on any funtoken creation
  2. Renamed query TokenMapping -> FunToken
  3. Added cli query for FunToken

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The changes encompass a thorough refactoring of the EVM module, emphasizing the management of fungible token events, CLI commands, and queries. Key updates include renaming functions and messages for clarity, enhancing CLI command structures for better usability, and aligning tests with the new configurations. This refactoring seeks to enhance the overall interaction with fungible tokens within the system, making operations more intuitive and efficient.

Changes

Files Change Summary
CHANGELOG.md Added summary of changes regarding funtoken events, CLI commands, and queries in the EVM module.
eth/rpc/backend/mocks/evm_query_client.go Renamed TokenMapping to FunTokenMapping, updated request and response types accordingly.
proto/eth/evm/v1/events.proto Renamed EventFunTokenFromBankCoin to EventFunTokenCreated, added is_made_from_coin field.
proto/eth/evm/v1/query.proto Renamed RPC methods and message types to reflect fun token terminology.
x/evm/cli/query.go Introduced new CLI commands for querying fun token functionalities in the evm module.
x/evm/cli/tx.go Updated existing CLI commands and added new ones for creating and sending fungible tokens.
x/evm/keeper/erc20_test.go Updated tests to use Require assertions, added checks for specific events and attributes.
x/evm/keeper/grpc_query.go Renamed TokenMapping function to FunTokenMapping, updated input and return types.
x/evm/keeper/grpc_query_test.go Renamed TestQueryTokenMapping to TestQueryFunToken, updated types throughout the function.
x/evm/keeper/msg_server.go Updated event emission in CreateFunToken to emit EventFunTokenCreated with additional details.

Poem

In the code where tokens prance,
Refactor sings a joyful dance.
Funtoken events, freshly spun,
Queries sparkle, all in fun.
CLI commands, a breeze to wield,
A rabbit's cheer, a tech-filled field.
πŸŒŸβœ¨πŸ‡

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.95%. Comparing base (f898bae) to head (777ab3a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1968 +/- ## ======================================= Coverage 65.95% 65.95% ======================================= Files 258 258 Lines 16384 16384 ======================================= Hits 10806 10806 Misses 4772 4772 Partials 806 806 ``` | [Files](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1968?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain) | Coverage Ξ” | | |---|---|---| | [x/evm/keeper/grpc\_query.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1968?src=pr&el=tree&filepath=x%2Fevm%2Fkeeper%2Fgrpc_query.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9ldm0va2VlcGVyL2dycGNfcXVlcnkuZ28=) | `83.76% <100.00%> (ΓΈ)` | | | [x/evm/keeper/msg\_server.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1968?src=pr&el=tree&filepath=x%2Fevm%2Fkeeper%2Fmsg_server.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9ldm0va2VlcGVyL21zZ19zZXJ2ZXIuZ28=) | `71.57% <100.00%> (ΓΈ)` | |