Nicholas-Cheng-De-Fei / pe

0 stars 0 forks source link

Too restricted phone number #2

Open Nicholas-Cheng-De-Fei opened 1 week ago

Nicholas-Cheng-De-Fei commented 1 week ago

Screenshot of Error

image.png

How to Replicate

add n/John Doe p/987654321 e/johnd@example.com addr/311, Clementi Ave 2, #02-25 b/1990-10-10 appt/2024-12-12 12:00

Description

image.png

I feel that as a insurance agent not all phone numbers will be exactly 8 characters long like in Singapore. In other countries it might be longer. Thus I feel that the limiting to 8 is not needed. But if you were to limit the phone number by international standards the maximum length is 15. This I feel that based on the target audience and their operations you should change the limit to be 15 instead.

nus-pe-bot commented 1 week ago

Team's Response

The team understand that this might be a potential issue in the future, and has considered expanding the number of digits the phone number can hold. However, the fix is considered a low priority fix as including longer phone numbers means more test cases needs to be created to ensure it is properly integrated into our existing application. As such, the current iteration assumes up to 8 digit. Thus, the team believe that this is considered "NotInScope". Do let us know your thoughts. Thanks! :)

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]