search

NicholasBrinkel / Chizu

Mapping App
1 stars 0 forks source link

Review develop changes #14

Open brandon-salahat-tm opened 5 years ago

brandon-salahat-tm commented 5 years ago

I'll open PRs for the feature changes I am working on when they are ready, but I pushed some bug/stability updates to develop. You might want to take a look at the commit diffs and make sure they won't break anything. I tested them on two iPad simulators, 3 iPhone simulators, and my personal devices.

  1. The main map and floating panel size/position better, and relative to the device screen size instead of the hardcoded values. The hardcoded values were making it display really poorly on iPads. This also keeps the main map from ever being obfuscated by the fully collapsed FPC.

  2. Search bar doesn't break the app anymore. If it summons the keyboard the FPC expands so that everything isn't covered by the keyboard. It will collapse to the previous state and dismiss the keyboard when the cancel button or the search button are pressed. (The hide keyboard button will not collapse the FPC, but that should be a normal looking experience)

  3. Converted the Main Map pdf to a png. The method I am going to use to hide the POI locations in the image file are documented as not working well with pdf assets. Tested it on high resolution simulators, still looks fine. Shouldn't be any loss of detail.

I can try to add some pretend search functionality if we want locations besides the E2 favorite. Going to focus on the POIs for now though.

brandon-salahat-tm commented 5 years ago

cc @shay0n in case you care about this for some reason

brandon-salahat-tm commented 5 years ago

@NicholasBrinkel also pushed up a proof of concept to the POI branch. Seems to place things pretty close to pixel perfect across different devices automatically, so I'm going to go with it for the POI pins. May not get to finishing it tonight because I have some other stuff to do though.