search

NicholasTagher / SportsCalendar

For my sports calendar
0 stars 0 forks source link

Hard coding API keys is a bad practice, you should keep them as ENV variables #1

Open Victornovikov opened 3 years ago

Victornovikov commented 3 years ago

https://github.com/NicholasTagher/SportsCalendar/blob/b7d4f8509baa3c3d615ae16f14e63fb6a666ec4f/main.py#L14

Victornovikov commented 3 years ago

since it is a public repo you should probably rotate your keys now..

Victornovikov commented 3 years ago

same goes for PII https://github.com/NicholasTagher/SportsCalendar/blob/b7d4f8509baa3c3d615ae16f14e63fb6a666ec4f/main.py#L134

NicholasTagher commented 3 years ago

Yes, they sent me a message right away telling me the keys were changed. I have to update it

On Wed, May 19, 2021 at 3:30 PM Victor @.***> wrote:

same goes for phone numbers from_='+16107562602',

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/NicholasTagher/SportsCalendar/issues/1#issuecomment-844405701, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOOPCJU55PV4Z2AWD3OGS3TOQGWDANCNFSM45FKUAYA .

NicholasTagher commented 3 years ago

What is an ENV variable? I thought it was such, because I store it then feed the variable into the Client field?

On Wed, May 19, 2021 at 3:26 PM Victor @.***> wrote:

https://github.com/NicholasTagher/SportsCalendar/blob/b7d4f8509baa3c3d615ae16f14e63fb6a666ec4f/main.py#L14

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/NicholasTagher/SportsCalendar/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOOPCP6ZPWXYSOL5P7QPD3TOQGG5ANCNFSM45FKUAYA .

Victornovikov commented 3 years ago

https://www.twilio.com/blog/environment-variables-python

NicholasTagher commented 3 years ago

Hi, so I uploaded the new files by using functions. I also used the ENV variables

On Wed, May 19, 2021 at 10:30 PM Victor @.***> wrote:

https://www.twilio.com/blog/environment-variables-python

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NicholasTagher/SportsCalendar/issues/1#issuecomment-844635619, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOOPCLGRTRCQ2PT5T4UI5DTORX45ANCNFSM45FKUAYA .