Nick9500 / ministocks

Android Stocks Widget
http://niteshpatel.github.io/ministocks
MIT License
1 stars 2 forks source link

As a Developer, I'd like to incorporate a static analysis tool into the CI system #62

Closed Nick9500 closed 6 years ago

Nick9500 commented 6 years ago

It is often advantageous to include static analysis tools into continuous integration build systems. This could be Linters for syntax, or SonarQube as suggested by the TA/Instructor. As a developer, I'd like to incorporate a static analysis tool into the CI system. [SP: 3] [Priority: 1] [Risk: High]

Demo N/A (under the hood)

Tasks: Investigate which static analysis tool to integrate. Figure out how to incorporate it to CircleCI. Incorporate the changes to CircleCI.

Nick9500 commented 6 years ago

I don't need PHPUnit since we're using Java. Don't know what I was thinking...

Nick9500 commented 6 years ago

This CI feature will be ready for Release 3, it's so close to being finished. To update, we decided that CodeClimate should do the trick with CircleCI. See (https://codeclimate.com/github/Nick9500/ministocks). It's set up currently to initialize analysis upon merging to Master but this is not due to changes in a config.yml file.. CodeClimate has built-in integration into Github. Need to consult Max about this.

Nick9500 commented 6 years ago

afoaoa Okay'ed by Max at the release meeting on April 9th.

Nick9500 commented 6 years ago

Configured to run CodeClimate static analysis on every push (branch, or master).

Nick9500 commented 6 years ago

afssa Showing a failing CodeClimate check that prevents merging.