search

NickChapman / RequestNetwork.py

A python implementation of the Request Network API
MIT License
13 stars 5 forks source link

Web3Single implementation #17

Closed ghost closed 6 years ago

ghost commented 6 years ago

Implemented most of Web3Single, closes #12

ghost commented 6 years ago

@varuna82 You are correct, it should be transact instead of send

varuna82 commented 6 years ago

@justicesuh I am bit skeptic about following lines too. I have tried to get following events in my test env, but it generates a runtime error saying "method not found". It looks like 'transactionHash' isn't supported by web3.py. Actually, web3.py and web3.js are totally different when it comes to event filtering.

@NickChapman what are your thoughts on this?

   .on('transactionHash', callbackTranactionHash)
   .on('receipt', callbackTransactionReceipt)

This could be the most difficult part to port. So, good luck with it...

ghost commented 6 years ago

@varuna82 Yea, web3.py and web3.js have very different apis (the web3.py api differs pretty significantly between versions too). My thoughts were to port the general structure of the code first and then deal with differences in underlying api calls later (mainly web3 calls).

@NickChapman thoughts?

NickChapman commented 6 years ago

I would say open an issue and see if you can get it to raise an error for those events and we'll deal with it later. Also you'll need to resolve this merge conflict.