search

NickChapman / RequestNetwork.py

A python implementation of the Request Network API
MIT License
13 stars 5 forks source link

Artifacts module implemention #6

Closed balsulami closed 6 years ago

balsulami commented 6 years ago

This module in RequestNetwork.js is made of JSON files. I don't have experience with Javascript. Should I convert each JSON into static class in Python or write a python script that loads those JSON files into Python object dynamically?

I'm planning to contribute to this project. I just need a small guidance.

Thanks

NickChapman commented 6 years ago

I have already implemented a class which will load the JSON files and allow you to interact with them as dictionaries.

balsulami commented 6 years ago

I see what you were trying to do. So it's the second option.

Also, The JSON files are empty. Is there a reason why you didn't copy the same files from the JS project? I could do that if there is no reason.

Thanks

NickChapman commented 6 years ago

Only reason is that I'm waiting to see if Vincent can put the artifacts into their own repo that we can just include as a submodule. If you want to copy them in for now that's fine.

balsulami commented 6 years ago

I see. I will copy them for now and we can change them later. Because It helped me testing and understanding the code a little bit. Thanks