search

NickCraver / StackExchange.Exceptional

Error handler used for the Stack Exchange network
https://nickcraver.com/StackExchange.Exceptional/
Apache License 2.0
860 stars 170 forks source link

Ben.Demystifier integration? #119

Closed smurariu closed 6 years ago

smurariu commented 6 years ago

Hey guys, Would it be an idea to integrate Ben's Demystifier (https://github.com/benaadams/Ben.Demystifier) before we store the exceptions? We would save space and also make the stack traces a little easier to understand.

NickCraver commented 6 years ago

I'm not sure about the integration by default since it up the cost of generating the exception significantly at log time, but I'm working with Ben to optimize it right now and we'll see what happens.

Regardless of default usage, I absolutely agree the plugin should have some way to work, and it should already via:

ex.Demystify().Log(...);
smurariu commented 6 years ago

Got it. I saw on twitter that you were working with ben on it and doing some benchmarking. Just wanted to make sure it's on your radar, so I will close this issue.