search

NickCraver / StackExchange.Exceptional

Error handler used for the Stack Exchange network
https://nickcraver.com/StackExchange.Exceptional/
Apache License 2.0
863 stars 171 forks source link

[WIP] ILogger integration #135

Open m0sa opened 6 years ago

m0sa commented 6 years ago

initial stab at ILogger integration, seems like we're getting duplicate entries now (host as well as middleware logging the same exception)

NickCraver commented 5 years ago

I got this working, tests in, etc. But there's a problem. We've started out with bad assumptions of basic flows here, and that's my fault. This needs a poke at possibly refactoring the queue behavior in an ErrorStore (maybe a timer instead of a thread...but that's not without downsides) and the ILogger only creates the Error and queues, but does not log to the store. Retry background behavior (which already exists, just not 1:1 with what we need here) would be to actually log the errors to the store. This needs to handle fetching behavior as well, as is currently the case only when in retry today but we can simulate that with a length check on the queue.

Going to poke this some more tonight and hopefully have a 2.2 RTM release this week.

Additional thought: this should be optional - we need to make it configurable.

mmillican commented 5 years ago

@NickCraver Any ideas on next steps here? I'd love to help out if you have any other ideas for your last comment.

mrahhal commented 4 years ago

This has been open for a long while. Any plans on ever continuing this? This sounds like a really great thing to have and would allow Exceptional to be the central place for viewing error-ish messages.