NickCraver / StackExchange.Exceptional

Error handler used for the Stack Exchange network
https://nickcraver.com/StackExchange.Exceptional/
Apache License 2.0
859 stars 170 forks source link

Update Styles.css to improve readability. #150

Closed turhanebev closed 5 years ago

turhanebev commented 5 years ago

Preserves indentation whilst wrapping long lines.

NickCraver commented 5 years ago

I was confused a bit here due to the branches - is this intentionally against the 1.x branch? It's there for reference only - I need to tidy a few bits and then RTM the v2 release (been available in RC status for a while).

turhanebev commented 5 years ago

Yeah that was intentional, I'm working on an existing system that was using 1.x

I figured it was a small enough change to include that way I can continue to use the nuget package and share it with anyone else who may also still be on 1.x.

Thanks.

NickCraver commented 5 years ago

I think this one is just a matter of opinion difference - I find it harder to read with the wrapping. But, if you want it to wrap, there's a facility for this in v1, like this:

ErrorStore.AddCSSInclude("~/Content/mycustom.css");

If you want to tweak any of the built-in styling, you can have any error pages pull in your custom .css (and there's a JavaScript .AddJSInclude() as well). That's how it's supported for everyone's taste in v1 - hope this helps :)

turhanebev commented 5 years ago

Interesting I found panning left/right harder (always need to scroll right to see the issue), whilst still better than regular wrapping but far worse than wrapping whilst preserving indentation.

That's fair though thanks for the include info :)