NickCraver / StackExchange.Exceptional

Error handler used for the Stack Exchange network
https://nickcraver.com/StackExchange.Exceptional/
Apache License 2.0
863 stars 171 forks source link

Fix failure mode view details button when there are no errors yet #157

Closed MattJeanes closed 5 years ago

MattJeanes commented 5 years ago

Whipping these fixes out today!!

I noticed that one of our sites using Exceptional was in failure mode which was ok but the 'view details' button wasn't working at all.

Eventually worked out it was because there's a bit of code in the javascript that stops all the handlers being loaded if the table has nothing in it - but this also included the code that made that button work, so just moved it up a bit basically before that check.

Used Bundler & Minifier extension to rebuild the bundle files, seems to have worked ok!

Happy to fix it a different way if you prefer, but this seems to work fine.

NickCraver commented 5 years ago

Ah good catch and fix, thank you!

MattJeanes commented 5 years ago

Happy to help. Thanks for accepting 😄