NickCraver / StackExchange.Exceptional

Error handler used for the Stack Exchange network
https://nickcraver.com/StackExchange.Exceptional/
Apache License 2.0
863 stars 171 forks source link

Adding 'name' property to <Exceptional> config section. #37

Closed ryan1234 closed 10 years ago

ryan1234 commented 10 years ago

We like to put the environment in our application names. Things like "REST API (dev)" and "REST API (prod)".

The problem is that when we want to do an xdt transformation on our web.configs, we have no elements to transform on since application name will vary per environment.

Adding an optional "name" property to allow xdt transformations. Shouldn't break existing configs and allows application name to change with environments.

NickCraver commented 10 years ago

I'm not understanding why you can't transform on applicationName that exists currently? Hopefully you can understand why I'm very reluctant to introduce a property here which adds a good deal of confusion.

The entire Exceptional section itself can be found via xpath/xdt, why does this not work in your case?

ryan1234 commented 10 years ago

Yeah let me try again with the entire section.

On Wed, Jan 8, 2014 at 5:31 PM, Nick Craver notifications@github.comwrote:

I'm not understanding why you can't transform on applicationName that exists currently? Hopefully you can understand why I'm very reluctant to introduce a property here which adds a good deal of confusion.

The entire Exceptional section itself can be found via xpath/xdt, why does this not work in your case?

— Reply to this email directly or view it on GitHubhttps://github.com/NickCraver/StackExchange.Exceptional/pull/37#issuecomment-31894920 .

ryan1234 commented 10 years ago

This fixed my local problem, but was a bad idea.