search

NickCraver / StackExchange.Exceptional

Error handler used for the Stack Exchange network
https://nickcraver.com/StackExchange.Exceptional/
Apache License 2.0
863 stars 171 forks source link

Make jQuery URL configurable #48

Closed cremor closed 10 years ago

cremor commented 10 years ago

Could you please make the jQuery URL that is used in all pages configurable? Currently it's always loaded from the Google CDN, which isn't very good if you want to use StackExchange.Exceptional in an environment without internet access (e.g. internal web applications).

I know that there is already the possibility to include custom JavaScript files, but this doesn't work since they are included after the page tries to execute the script that is shipped with StackExchange.Exceptional, and that script already requires jQuery.

NickCraver commented 10 years ago

Making it code configurable is not a problem at all, I'll get this into a round of library updates I'm doing next week.

NickCraver commented 10 years ago

jQuery is now configurable in code, [an example has been added to the sample project here[(https://github.com/NickCraver/StackExchange.Exceptional/blob/aad0cd0582f7988ae0afddcc1745af5bd71f3c5a/Samples.MVC4/Global.asax.cs#L40): 

// Setting the jQuery URL, in case you need this to be an internally hosted jQuery for example
// By default, this will pull from the google CDN
ErrorStore.jQueryURL = "//ajax.googleapis.com/ajax/libs/jquery/1.10.2/jquery.min.js";

Nuget is also deployed with this change. Can you confirm you're all set? I'll wait to close this out until you can chime in.

cremor commented 10 years ago

Works great, thanks!