Closed OlivierBinette closed 6 months ago
This looks great and I would totally accept a PR, or I can do it myself.
Even if we don't test against multiple backends, then column_factory and table_factory functions would be great to remove boilerplate.
@OlivierBinette if you want, take a look at that commit and let me know if I missed something there.
The tests currently use
ibis.memtable
to construct tables used as an input. This relies on the backend provided byibis.options.default_backend
.I think it would be good to have more control over the backend for tests. We don't want individual test files to worry about this, so we could have a
conftest.py
file that provides ibis connection objects and table constructors.For instance, in
conftest.py
, we could have the following:Individual test files cane then use the
table_factory
andcolumn_factory
fixtures to define the test data they need. And we have all the control we want over the backend, Ibis connection, and the scoping of these objects, without any of the individual test files having to worry about it.