CaseAwarePath fails on macOS but not Linux?

NickHugi / PyKotor

A Python library that can read and modify most file formats used by the game Knights of the Old Republic and its sequel.

GNU Lesser General Public License v3.0

11 stars 3 forks source link

CaseAwarePath fails on macOS but not Linux? #63

Closed th3w1zard1 closed 6 months ago

th3w1zard1 commented 6 months ago

https://htmlpreview.github.io/?https://github.com/NickHugi/PyKotor/blob/0f9be54d8c1c8d10bcdd94515f29b4f4fc1ab77f/tests/results/2afd8e71e7330a530d3936529dfb5b37343a5dda/pytest_report_macos-12_3.8_x64/pytest_report.html

The tests/common/test_get_case_sensitive_path.py::TestCaseAwarePath::test_make_and_parse_uri and test_relative_to tests are failing on macOS, but not linux. Very bizarre. Is happening on all tested python versions.

th3w1zard1 commented 6 months ago

I'm stumped. There's no Linux-specific code anywhere...

th3w1zard1 commented 6 months ago

I've figured out the problem. Apparently many macOS filesystems use APFS which is typically configured to be case-insensitive... I had no idea. So I should be checking if the filesystem is linux-specifically, or for the string tests i should be checking if it fails and os is macos then I can ignore that portion.

th3w1zard1 commented 6 months ago

Fixed.