search

NickHugi / PyKotor

A Python library that can read and modify most file formats used by the game Knights of the Old Republic and its sequel.
GNU Lesser General Public License v3.0
11 stars 3 forks source link

Use Editor.save logic in NSSEditor.compileCurrentScript fixes #68 #77

Closed JoeNotCharles closed 5 months ago

th3w1zard1 commented 5 months ago

When a compilation fails on this PR, the window title still seems to change, implying self._filepath/self._resname/self._restype are changing. Can you address this please @JoeNotCharles ?

JoeNotCharles commented 5 months ago

Works for me...

If I foo.nss file, use "File / Save As", and choose the filename foo.ncs, the window title changes to foo.ncs even if the compile fails. That happens with origin/master, too, so no change to Save As with this patch.

If I choose "File / Compile" instead, it automatically tries to compile it to foo.nsc, and wether it succeeds or fails the window title stays as foo.nss for me. (Although it switches to .nsc during the compile and then switches back when it's done.)

On Thu, Mar 14, 2024 at 8:58 AM Benjamin Auquite @.***> wrote:

When a compilation fails on this PR, the window title still seems to change, implying self._filepath/self._resname/self._restype are changing. Can you address this please @JoeNotCharles https://github.com/JoeNotCharles ?

— Reply to this email directly, view it on GitHub https://github.com/NickHugi/PyKotor/pull/77#issuecomment-1997402987, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMDPPYCKXHMY2UPM3YUBBLYYGNIRAVCNFSM6AAAAABETJL3P6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJXGQYDEOJYG4 . You are receiving this because you were mentioned.Message ID: @.***>

th3w1zard1 commented 5 months ago

If I foo.nss file, use "File / Save As", and choose the filename foo.ncs, the window title changes to foo.ncs even if the compile fails. That happens with origin/master, too, so no change to Save As with this patch. I was wondering if it was able to be addressed here, not trying to imply it was caused by this PR. I'm aware this behavior can be observed on master. I definitely didn't make that clear and I'm sorry about that!

We can address in another PR if it would fit better there.

On Thu, Mar 14, 2024 at 10:35 PM Joe Mason @.***> wrote:

Works for me...

If I foo.nss file, use "File / Save As", and choose the filename foo.ncs, the window title changes to foo.ncs even if the compile fails. That happens with origin/master, too, so no change to Save As with this patch.

If I choose "File / Compile" instead, it automatically tries to compile it to foo.nsc, and wether it succeeds or fails the window title stays as foo.nss for me. (Although it switches to .nsc during the compile and then switches back when it's done.)

On Thu, Mar 14, 2024 at 8:58 AM Benjamin Auquite @.***> wrote:

When a compilation fails on this PR, the window title still seems to change, implying self._filepath/self._resname/self._restype are changing. Can you address this please @JoeNotCharles https://github.com/JoeNotCharles ?

— Reply to this email directly, view it on GitHub https://github.com/NickHugi/PyKotor/pull/77#issuecomment-1997402987, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAMDPPYCKXHMY2UPM3YUBBLYYGNIRAVCNFSM6AAAAABETJL3P6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJXGQYDEOJYG4>

. You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/NickHugi/PyKotor/pull/77#issuecomment-1998878789, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQ56PBOOFJEXWV57ELPZYTYYJT7JAVCNFSM6AAAAABETJL3P6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJYHA3TQNZYHE . You are receiving this because you commented.Message ID: @.***>

th3w1zard1 commented 5 months ago

LGTM. Let's address that bug in another PR 🗡️