search

NickHugi / PyKotor

A Python library that can read and modify most file formats used by the game Knights of the Old Republic and its sequel.
GNU Lesser General Public License v3.0
11 stars 3 forks source link

Add a setting to look for NSS files before decompiling NCS #78

Closed JoeNotCharles closed 2 months ago

JoeNotCharles commented 5 months ago

<when opening an NCS resource, let the user pick an NSS from Vanilla_KOTOR_Script_Source instead of decompiling implemented in PR> #75

th3w1zard1 commented 5 months ago

Looks good to me. Worked fine during testing. Please let me know when you'd like this merged. Not sure if you're planning any extra features here or whatnot.

JoeNotCharles commented 5 months ago

I won't have time to work on it more for a while, so might as well merge it now. The biggest thing it's missing is checking that the NSS matches the NCS for safety, which is why I turned the setting off by default, but I think we can merge it as a use-at-your-own-risk feature like RIM saving

On Thu, Mar 14, 2024, 08:55 Benjamin Auquite @.***> wrote:

Looks good to me. Worked fine during testing. Please let me know when you'd like this merged. Not sure if you're planning any extra features here or whatnot.

— Reply to this email directly, view it on GitHub https://github.com/NickHugi/PyKotor/pull/78#issuecomment-1997395088, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMDPP7FHYV66FQGYNLSSZTYYGM3DAVCNFSM6AAAAABETJTW6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJXGM4TKMBYHA . You are receiving this because you authored the thread.Message ID: @.***>

th3w1zard1 commented 5 months ago

I won't have time to work on it more for a while, so might as well merge it now. The biggest thing it's missing is checking that the NSS matches the NCS for safety, which is why I turned the setting off by default, but I think we can merge it as a use-at-your-own-risk feature like RIM saving

That logic alone will be a pain to write, maybe @NickHugi could take a look as the NCS objects are part of his compiler code.

th3w1zard1 commented 2 months ago

idea improved upon and implemented in another PR.