NickImpact / GTS

A take on the Global Trading Station from the Pokemon Games, expanded to a full developer API
GNU General Public License v3.0
17 stars 28 forks source link

Add a button for setting the price to a percentage of the Pixelmon NPC shopkeeper prices #122

Closed Varijon closed 3 years ago

Varijon commented 3 years ago

What are you trying to do? When listing items on GTS, players often want to sell at a percentage (usually 50%) of the price the NPC shops are selling items.

Describe the solution you'd like I would like to see a button on the create listing screen that shows the shop price and when the user clicks this, it asks them a percentage to set the listing price per item to.

Describe alternatives you've considered With the old plugin, I made a simple command that ran the /gts sell command for doing this, as that command is no longer supported it might be of use in the actual plugin.

Anything else that might help? I will provide the code I used after a fair bit of research on how to get the shop item prices, I don't know if this is the most efficient way to do it, but it's a process of trial and error. You can retrieve the global buy/sell price the pixelmon config is using for NPC shopkeepers via this route.

Link to command code

NickImpact commented 3 years ago

Not too sure on this one from the public side. The item module is meant to be as vanilla as possible, and I’m not keen on having it rely on a mod just to provide more. Besides, with the way the system is designed, it shouldn’t be difficult for them to choose how best to sell it. Because I’m sure someone isn’t gonna want to sell at 50%, but rather 75% or even something else.