A few issues with Pokemon eggs

SirDoof commented 3 years ago

What is the bug? So i've got 2 issues with poke eggs:

In the reforged config, I've set allow-eggs = false but they can be sold and bought. They don't hatch tho.
You can see an egg's info such as ivs which I don't want on my server Do let me know if it does disable eggs properly for you.

What version of GTS are you running? 6.1.8

What version of Sponge are you running? 7.3.0

Provide a link to the file generated by /nucleus info N/A

To Reproduce Steps to reproduce the behavior:

Go to sell a poke
Choose egg in party
Sell egg

Expected behavior Not being able to sell eggs or see its info

Error logs N/A

NickImpact commented 3 years ago

First bit is likely just an unimplemented section. Second bit I still remain hesitant on, as the idea I had was that eggs shouldn't be a gamble. The compromise I believe is best is simply showing only the species information (form and what not) so there's at least something. Want people to know what they're buying before just spending and realizing they bought something terrible.

SirDoof commented 2 years ago

Been thinking about this and actually I don't think i'd need you to change the egg info if the allow-eggs got implemented.

NickImpact commented 2 years ago

In latest snapshots as of https://github.com/NickImpact/GTS-Pixelmon-Extension/pull/6

NickImpact / GTS

A few issues with Pokemon eggs #141