search

NickImpact / GTS

A take on the Global Trading Station from the Pokemon Games, expanded to a full developer API
GNU General Public License v3.0
17 stars 28 forks source link

Chinese Translation #98

Closed ShiratsuYudachi closed 3 years ago

ShiratsuYudachi commented 3 years ago

I made a Chinese language file

zh_cn.conf.txt

NickImpact commented 3 years ago

Awesome, will take a look and integrate into the base plugin if approved

ShiratsuYudachi commented 3 years ago

another question, can I post GTS on mcbbs(a Chinese Minecraft Forum)? I will put https://ore.spongepowered.org/NickImpact/GTS as the download link.

NickImpact commented 3 years ago

It's looking good for the most part, just a few untranslated lines I see in there. Once you get those done, I'll integrate into the next release, which will likely be 6.1.0, following tonight's 6.0.10 patch.

As for posting on a forum, feel free, but do keep download links posted to their original point of origin where possible. Though you're allowed to redistribute the content, you definitely don't want to be the one responsible for the plugin I'm sure.

ShiratsuYudachi commented 3 years ago

zh_cn.conf.txt I translated the part of discord and some missing lines, but still there are some button like the switch between Quick Perchase and Auctions in browser as well as the arrows named 'previous page' and 'next page' that I can't found them in the language file. Perhaps the lore and name of them have already set in the code?

NickImpact commented 3 years ago

Those are fine, I believe that's coming from Impactor so GTS doesn't have the ability to translate them at this present moment. Something I should change for future versions.

Will double check and integrate with 6.1.0 changes.

NickImpact commented 3 years ago

Will update this ticket with the file provided and any new lang keys that are added, given some will be added with 6.1's new admin features.

NickImpact commented 3 years ago

Added as current in https://github.com/NickImpact/GTS/commit/595ea7a69ccde0bd4abdba1b625fcd4997288b98.

Will close this ticket as future updates to the default language file should be handled via pull requests. Thanks your your translations.