NickLiffen / ghas-enablement

A tool that aims to bulk automates the enablement of GitHub Code Scanning, Secret Scanning and Dependabot across multiple repositories.
152 stars 52 forks source link

move @octokit/plugin-retry to devDependencies #106

Closed joshjohanning closed 1 year ago

joshjohanning commented 1 year ago

Not sure if it was just me having this problem, but I had this problem both locally and in a Codespace.

node -v && npm -v

v18.11.0
8.19.2

When running a fresh clone and setup:

npm install
npm run build

src/utils/clients/core.ts:9:23 - error TS7016: Could not find a declaration file for module '@octokit/plugin-retry'. '/Users/joshjohanning/Repos/ghas-enablement-clean/node_modules/@octokit/plugin-retry/dist-node/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/octokit__plugin-retry` if it exists or add a new declaration (.d.ts) file containing `declare module '@octokit/plugin-retry';`

9 import { retry } from "@octokit/plugin-retry";
                        ~~~~~~~~~~~~~~~~~~~~~~~

Found 1 error in src/utils/clients/core.ts:9

When running this which adds this as to devDependencies instead, it works:

npm i --save-dev @octokit/plugin-retry

Builds:

npm run build

> github-helper@1.0.0 build
> npx tsc
NickLiffen commented 1 year ago

lgtm 👍

joshjohanning commented 1 year ago

:shipit: ?

😄