search

NickLucche / stable-diffusion-nvidia-docker

GPU-ready Dockerfile to run Stability.AI stable-diffusion model v2 with a simple web interface. Includes multi-GPUs support.
MIT License
357 stars 43 forks source link

Advanced web UI (hlky) #6

Open mchaker opened 2 years ago

mchaker commented 2 years ago

I've tried using this web UI and it seems more featured: https://github.com/hlky/stable-diffusion-webui

Specifically the face fix and upscale models I was able to add and enable.

Is there a way I could use that web UI with your docker container release?

NickLucche commented 2 years ago

Hey, this is a really comprehensive project I was unaware of, thanks for sharing that. I'm afraid that the simplest solution here would be to containerize their release, the UI seems to have many features that either depend on other models (upsampling) or add additional post-processing, it wouldn't be very wise to port that. Perhaps you could open an issue on their repo about it.

mchaker commented 2 years ago

Sounds good, I'll look into containerizing (or asking them for containerizing) their UI :)

angelmankel commented 1 year ago

Would it be hard to set up endpoints to allow a react frontend for this project? I would be willing to make a React UI with some (or possibly all with some help) of those same features. I think having a proper image gallery where you can compare/recall/etc would be great for artists as well instead of the terrible gradio one. I just don't know flask/django to set up the backend part of it.

NickLucche commented 1 year ago

Yep I agree I think it could be a nice feature to have. I can setup a flask/django app for serving the .js files as well as a rest API for doing the same things you can do with gradio right now. I know very little about react tho so I wouldn't be able to help on that side.

angelmankel commented 1 year ago

That would be awesome if you could set that up. I could handle the React side of things. If you'd like, I can let you know when I have a good idea of how the UI should look/function before I actually do any coding. The community might have some input on that as well. If so, just let me know where I should do that exactly since this is a bit unrelated to the original issue opened here. (I'm not very familiar with Github best practices yet)

NickLucche commented 1 year ago

Sounds great, let me know when you have a mock-up you might want to share. To do so, it would be best to open a new issue and discuss about the changes there. To add the code later on, you should fork this repo and make a new branch with the js files!

NickLucche commented 1 year ago

@angelmankel I've tested a simple flask server (here) for serving a sample react app and it seems to be working. I've created a test app in the root folder using npx create-react-app stable-diffusion-ui.

On the second thought, I think I can actually set up a separate repo for the react UIx that we can then link as a github submodule. You can find the sample react app here https://github.com/NickLucche/stable-diffusion-react-ui.

angelmankel commented 1 year ago

Wow that was fast. This is great, I will get back to you with a mock-up in the new repo soon! Thanks for getting this all started, really looking forward to working on this.