search

NickMcBurney / storybook-vue3-router

A Storybook decorator that allows you to use Vue 3 / vue-router@4 routing-aware components.
MIT License
29 stars 8 forks source link

[next]: Upgrading to storybook@7.0.0-rc.4 #40

Closed NickMcBurney closed 1 year ago

NickMcBurney commented 1 year ago

Published prerelease version: v3.0.0-next.1

Changelog #### 💥 Breaking Change - Storybook v7 Support [#39](https://github.com/NickMcBurney/storybook-vue3-router/pull/39) ([@NickMcBurney](https://github.com/NickMcBurney)) #### 🐛 Bug Fix - Storybook@7.0.0-rc.4 update and package upgrades [#40](https://github.com/NickMcBurney/storybook-vue3-router/pull/40) ([@NickMcBurney](https://github.com/NickMcBurney)) #### Authors: 1 - Nick McBurney ([@NickMcBurney](https://github.com/NickMcBurney))
louia commented 1 year ago

When I try to install this version with :

npm i storybook-vue3-router@3.0.0-next.1 -D

I got this message : image

NickMcBurney commented 1 year ago

@louia, Its best to raise issues in the Issues section rather than on a closed PR. Looking at versions the x-range constraint used in this package 7.x should work with 7.0.0-rc.8 , this can be confirmed here: https://jubianchi.github.io/semver-check/#/7.x/7.0.0-rc.8

There is a few options which may help:

  1. Delete node_modules + package-lock.json, then run npm i
  2. If above does not work, then try running npm install --save --legacy-peer-deps

Would also be helpful to know what version of node/npm you're running.

Hoping first suggestion fixes for you.

louia commented 1 year ago

Thanks for your response.

I have node v18.14.0 + npm 9.4.2. I get also the same error with your latest release after update my project to use rc9 of storybook.

When I do manual command npm i @storybook/vue3@7.x I also got this message : image

And this is the error with the command npm install --save-dev storybook-vue3-router@next image

I can't run npm i with --legacy-peer-deps in my company because it break the ci.

NickMcBurney commented 1 year ago

@louia I think I may have resolved the issue - I've just published a new version 3.0.0-next.3

PR is here: https://github.com/NickMcBurney/storybook-vue3-router/pull/43

I've updated to @storybook@7.0.0-rc.10 and also amended how peerDependencies are specified which I expect should now work for you.

louia commented 1 year ago

It fix my problem, thanks !