search

NickMcConnell / FAangband

First Age Angband
http://nickmcconnell.github.io/FAangband/
85 stars 15 forks source link

Pull in V changes #82

Open NickMcConnell opened 3 years ago

NickMcConnell commented 3 years ago

Will leave this open while https://github.com/angband/angband/issues/4934 is active.

Current commit which is difficult to cherry-pick is https://github.com/angband/angband/commit/73f2fe39d170fee25b5d09f04c716770c2bd2ee1

NickMcConnell commented 3 years ago

angband/angband@73f2fe3 now in, but bad uses of player global need fixing.

NickMcConnell commented 3 years ago

https://github.com/angband/angband/commit/32438ce3563af2ed449cf5c2738efb070e9125a6 is the problem now. Fixed now.

NickMcConnell commented 3 years ago

Everything done for now, but leaving open as promised.

NickMcConnell commented 3 years ago

Setting to Ongoing like the V issue.

NickMcConnell commented 3 years ago

Need to check whether any of https://github.com/angband/angband/commit/ab8b491f182dc7a7991f3a8dfd28cf774913d75a needs to come in (at least in spirit).

EDIT: The decision here comes down to whether to maintain a record of the player's quest completions in quests, or to put a separate field in struct player to hold that info.