Code Review Comments Adam Del Rio

[AdamDelRio]

1. Relabel the function ‘post_deliver_bottles’ in groups
2. Relabel the function ‘post_deliver_bottles’ in users
3. Utilize comments for a better understanding of what is happening 4, Return correct HTTP error codes
4. Consider changing the return ‘OK’ in ‘post_group_purchase’ to something more informative that shows that the function worked as intended
5. Have a function that checks if an inputted email is valid
6. Have a function that checks if an inputted phone number is valid
7. Disallow negative prices for paying another user (i.e. check price > 0), as this is directly charging them, which I’m sure could be used improperly
8. Utilize transactions to ensure the entire transaction will be rolled back if it does not work correctly
9. Add more description to variable names (such as uid, gid, uid2, etc)
10. Maybe spread complex SQL queries into multiple different statements that are joined later for readability
11. Utilize decimal instead of float for better precision

[jackalnom]

For #8, what line did you not see them using transactions?