NickPerlich / Bettermo

1 stars 1 forks source link

Schema/API Design comments Ivan Nghi #15

Open ivannghi opened 11 months ago

ivannghi commented 11 months ago

Some endpoints coded but not detailed and unsure what they do. Add them to the api spec description. Add API key. Change name of render site, on /docs still says central coast cauldrons. You could include remove endpoints for the resolved transactions. Detail what happens specifically in the api spec, on the database side, etc. Some of your example flows are using incorrect values. Make the balances clear when calling th endpoint to determine who owes who money. Remove user from group is not implemented like the API spec mentioned. You could implement it for that functionality. Could make schema in users table not accept null values, because a user with null name and etc. does not make sense. Make use of the other fields asked for in the /users endpoint, or get rid of it, makes it seem like extra unused information asked for. Add the other user specs into the API spec file, there is no detail on these. Using the service, I think it would be nice to have a functionality to have a wa for all of my outstanding non-zero balances shown in a get. Also some issues when splitting between two people in a group, not sure if the intention is for it to be only split amongst the other people in he group excluding the person who initiated the transaction.