search

NickSramcik / banki-brunch

https://banki-brunch.vercel.app
49 stars 31 forks source link

Add questions data and random picker function #4

Closed cblanken closed 1 year ago

cblanken commented 1 year ago

This PR should complete issue #1. It picks a random question from a hard-coded list of The Bank questions (sourced from @20Jasper's API project with some reformatting) here and renders them on the main page when the GET QUESTION button is clicked.

random-questions-demo

cblanken commented 1 year ago

I did notice a couple times while testing that on refresh the same question would be re-rendered. I think it's because there's a small chance the random number generator picks the same index of the question list twice in a row.

I could try to fix it before we merge, or it might be a good issue for someone to sort out later.

20jasper commented 1 year ago

I think you already noticed, but some of the code tags are in the wrong spot since we didn't know what half this stuff was back then haha