search

NickStizzy / simbl

Automatically exported from code.google.com/p/simbl
0 stars 0 forks source link

Installation failure due to use of login shell #45

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Have a somewhat unusual login shell such as es or rc.
2. Run the SIMBL-0.9.9 installer

What is the expected output? What do you see instead?
Expected: Successful installation. Actual: A message that installation failed.

What version of the product are you using? On what operating system?
Version 0.9.9 on macosx 10.6.7. My shell is es.

Please provide any additional information below.
Here are some relevant lines from the log:

./postinstall: Stop SIMBL Agent
./postinstall: su -l hanche -c /bin/launchctl unload -F -S Aqua 
"/Library/ScriptingAdditions/SIMBL.osax/Contents/Resources/SIMBL 
Agent.app/Contents/Resources/net.culater.SIMBL.Agent.plist"
./postinstall: Warning: No math in this shell
./postinstall: launchctl: Couldn't 
stat(""/Library/ScriptingAdditions/SIMBL.osax/Contents/Resources/SIMBL"): No 
such file or directory
./postinstall: launchctl: Couldn't 
stat("Agent.app/Contents/Resources/net.culater.SIMBL.Agent.plist""): No such 
file or directory

The immediate problem is that my login shell (es) does not recognise the double 
quote as something special, so it ends up running the equivalent of 
/bin/launchctl unload -F -S Aqua 
'"/Library/ScriptingAdditions/SIMBL.osax/Contents/Resources/SIMBL' 
'Agent.app/Contents/Resources/net.culater.SIMBL.Agent.plist"', and of course 
launchctl has some difficulties finding a file named 
“"/Library/ScriptingAdditions/SIMBL.osax/Contents/Resources/SIMBL” (initial 
double quote included).

Original issue reported on code.google.com by han...@math.ntnu.no on 7 Apr 2011 at 2:20

GoogleCodeExporter commented 8 years ago 
I might add that one possible fix would be to replace

su -l $USER -c "/bin/launchctl unload -F -S Aqua \"${LAUNCHD_PLIST}\""

in the postinstall script by

su -l $USER -c "/bin/sh -c /dev/stdin" <<EOT
/bin/launchctl unload -F -S Aqua \"${LAUNCHD_PLIST}\"
EOT

thereby forcing the use of the Bourne shell. But one can hope there are less 
hacky ways to deal with the problem.

Original comment by han...@math.ntnu.no on 7 Apr 2011 at 2:23

GoogleCodeExporter commented 8 years ago 
Thanks for tracking this down. I'll push out a fix this week.

Original comment by ms...@gmail.com on 20 Apr 2011 at 6:25

GoogleCodeExporter commented 8 years ago

Original comment by ms...@gmail.com on 20 Apr 2011 at 6:25

GoogleCodeExporter commented 8 years ago 
Actually, that fix fails inside the installer.

I'm going to try:

sudo -u "$USER" -- /bin/launchctl load -F -S Aqua "${LAUNCHD_PLIST}"

Original comment by ms...@gmail.com on 4 Aug 2011 at 9:41

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Fixed with http://culater.net/dl/files/SIMBL-0.9.9a.zip

Original comment by ms...@gmail.com on 4 Aug 2011 at 10:09