search

NickWaterton / Roomba980-Python

Python program and library to control iRobot Roomba 980 Vacuum Cleaner
MIT License
367 stars 103 forks source link

Problem with Roomba i7 since 3.0.11 firmware upgrade #59

Open jmvedrine opened 4 years ago

jmvedrine commented 4 years ago

Hello, I am using this great library in a plugin for the French home automation system Jeedom. One of my users reported that since his Roomba i7 has been upgraded (in the last week of September) the plugin is no more working and he even unable to retrieve the password (even after trying many times). For all other users having different robot models (including me) the script is still working great so until now the problem seems limited to i7/i7+ I did a bit of debugging on his system and in fact the problem arise at connection step https://github.com/NickWaterton/Roomba980-Python/blob/master/build/lib.linux-x86_64-2.7/roomba/password.py#L127 because the robot is returning a 104 error connection reset by peer. After a search it appears that other have the same exact problem see ratsputin comment here https://github.com/home-assistant/home-assistant/issues/27028.

tidalf commented 4 years ago

Hello,

It seems they have changed the tls config, like indicated here : https://github.com/NickWaterton/Roomba980-Python/issues/39#issuecomment-538665656 this commit : https://github.com/zhouF96/Roomba980-Python/commit/ede7e95e5b10c7e1d52154815f96098859287365 fix the issue

NickWaterton commented 4 years ago

I have fixed the TLS problem. Let me know if there are still problems.

tidalf commented 4 years ago

thx !

crkochan commented 4 years ago

Any chance of getting this fix getting published to the pypi.org?

wuench commented 4 years ago

This 'fix' breaks it for me (windows/python37). Should be TLSv1_2 or just leave it as TLS and tell people to upgrade python to a version where the default of TLS translates into TLSv1_2.