small fixes

[ghost]

fixed gender error where me (gender f) didnt get the conditional dialogue for condoms, but got the elif. also edited dialogue adding spaces after "...".

[mizuotanu-nirera]

Some of these added whitespaces look good but some of them don't match the pattern we use. There are a few instances in MAS's script-topics.rpy where there is a space after the ellipsis indicating a pause in the middle of a sentence, but in the majority of cases there is usually none if the word following the ellipsis isn't capitalized.

[ghost]

i see! sorry then for the inconvenience! :) great job with the mod as always~

[NickWildish]

For the safesex topic, do we want to base what the player sees for what protection to use based on genitalia or gender? I would have figured the genitalia but I want to hear your opinion on why it should be gender instead.

[ghost]

ohhh i only fixed it bc it didnt work for me akjdkskdkd i input v genitalia, and am f gender. but i got elif dialogue. so i put gender there as a workaround. thats it :0

[ghost]

*else, not elif iirc

[NickWildish]

I just realized why that occurred. I hadn't replaced the "F" value with "V" for the genitalia option, that was my bad!

[NickWildish]

@mizuotanu-nirera Do you reckon there were any whitespaces in this pull worth keeping? Otherwise I'm just going to close it and fix the genitalia bug otter found.

[ghost]

its okay! ehehe! thanks for the fix. i really like this project so far, if you ever need any help, let me know! :) thanks again!

[NickWildish]

No worries. If you have any other ideas or changes you would recommend, don't hesitate to let us know in an issue or with another pull request.

[mizuotanu-nirera]

Do you reckon there were any whitespaces in this pull worth keeping? Otherwise I'm just going to close it and fix the genitalia bug otter found.

129, 171, 348, 798, 821, 859, 871, and 908 look good to me. Also, not entirely related but someone on the Discord pointed out earlier that there's a error on 865 where I missed a word (it should say "Hmm...I wasn't expecting you to pick her.").

@my-otter-self Thanks for submitting these. I feel a bit bad being such a stickler for such a minute detail and it would be a shame to throw out the whole PR.

[ghost]

it was my pleasure! i love to fix lil dialogue "mistakes" skdjskkdkd and these topics were so fun to me that i just had to help somehow! c: its no problem even if u throw the pr out, you guys have been so helpful~~

[NickWildish]

Just resolved the issue with the safe sex topic. If you could limit to the changes mizuotanu recommended (and also the error on line 865 if you want, or we can do that), then I'll be happy to accept the pull.

[ghost]

of course! i'll do this first thing in the morning. thanks a bunch and talk to you tomorrow~

[mizuotanu-nirera]

I'll submit a PR for the changes right now so you don't have to worry about it later.

[ghost]

oh! okay then! if you ever need anything else, let ne know~