PR #1046 changed the "Mouse Clicks" panel/button to "Mouse Events" instead, since mouse-related events could now be visible without clicking; a sensible change. However, the PR missed a few references to *.MouseClicks in the code, resulting in the tooltip for the button not showing up correctly.
This PR switches all references to *.MouseClicks to their respective *.MouseEvents versions in all language .xaml files in /Resources/Localization. Additionally, it updates the values for the text itself from "Mouse clicks" to "Mouse events" within the tooltip for English and French (because those are the two languages that I know).
It may be a good idea to let those on the localization teams know that "Mouse clicks" should be changed to "Mouse events" for consistency. I also noticed several references in the other files to S.MouseClicks.Warning.None—this string no longer appears, since it's not really possible for a recording not to have any generic "mouse events" like it is for clicks. It can probably be removed from the language files. I don't think either of these last two points are particularly urgent, though.
NickeManarin
commented
1 year ago
PR #1046 changed the "Mouse Clicks" panel/button to "Mouse Events" instead, since mouse-related events could now be visible without clicking; a sensible change. However, the PR missed a few references to
*.MouseClicksin the code, resulting in the tooltip for the button not showing up correctly.This PR switches all references to
*.MouseClicksto their respective*.MouseEventsversions in all language.xamlfiles in/Resources/Localization. Additionally, it updates the values for the text itself from "Mouse clicks" to "Mouse events" within the tooltip for English and French (because those are the two languages that I know).It may be a good idea to let those on the localization teams know that "Mouse clicks" should be changed to "Mouse events" for consistency. I also noticed several references in the other files to
S.MouseClicks.Warning.None—this string no longer appears, since it's not really possible for a recording not to have any generic "mouse events" like it is for clicks. It can probably be removed from the language files. I don't think either of these last two points are particularly urgent, though.This PR fixes #1200.
Screenshots
Before
After
Cheers,
-- Matt