search

NickeManarin / ScreenToGif

🎬 ScreenToGif allows you to record a selected area of your screen, edit and save it as a gif or video.
http://www.screentogif.com
Microsoft Public License
23.06k stars 2.15k forks source link

[Bug] newest gifski does not work with screengif #1214

Open Herr-Sepp opened 11 months ago

Herr-Sepp commented 11 months ago

Describe the bug Using the newest gifski dll creates broken gif files

To Reproduce Steps to reproduce the behavior:

  1. download newest gifski .dll from https://gif.ski/gifski-1.11.0.zip
  2. save as ... with gifski
  3. quality settings do not matter
  4. the gif is always 8,00 KB or 4,00 KB and broken

Expected behavior the .gif works

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

cherinyy commented 10 months ago

I noticed that they provide a shared library in 1.5.0, but ScreenToGif doesn't work with it. This means that ScreenToGif does not use the officially built Gifski shared library.

This issue should probably be closed and a feature request issue raised to allow the use of the official gifski shared library.

NickeManarin commented 10 months ago

This issue should probably be closed and a feature request issue raised to allow the use of the official gifski shared library.

I added support for it with v3 of the app (still in development), so I just nee to port back the changes to v2.

NickeManarin commented 9 months ago

I tested with that version and it works normally btw.

byzod commented 8 months ago

I tested with that version and it works normally btw.

How? What version are you talking about? I downloaded both https://gif.ski/gifski-1.11.0.zip and https://gif.ski/gifski-1.5.0.zip mentioned above but none of them working

Kekkin commented 3 months ago

It seems that the rust code rewrite made latest gifski DLL libraries (taken from the win/developer folder of the tar.gz archive) work again with S2G, albeit not properly:

1.14.1 and 1.14.4 have both problems with GIFs being sped-up (as if the new encoder build didn't respect frame delays) and an unexpectionally long pause at the end of the gif playback before it starts looping again. BTW: Does the "loop forever" option even work? It feels like the output gif still loops in my browser & irfanview when that option is disabled. Tested with the bundled-as-plugin DLL and with 1.14.4

An 1.14.1-specific issue is that it has visual glitches in the exported gif, but not sure if that's just gifski-specific. Regardless, 1.14.4 doesn't exhibit this problem.

Not sure of any other issues existing that haven't exhibited in the bundled-as-plugin library from 2020-09.

I attached the project file that I used to test gifski onto. Imported the gifski-1.14.4 output gif to a new project - all but the last frames are set to a 20ms delay, with the last frame being 16090 ms. Imported the output gif that was exported with the default gifski version (I believe it was 1.2.0, yeah?) to a new project, and the timings were intact.

Surprised to see the bundled gifski build working with variable frame delays, as seeing gifski's issue tracker - it's not really supported.

test_project.stg.zip