search

NickeManarin / ScreenToGif

🎬 ScreenToGif allows you to record a selected area of your screen, edit and save it as a gif or video.
http://www.screentogif.com
Microsoft Public License
23.06k stars 2.15k forks source link

[Bug] Editor - Statistics - duration unit wrong #1246

Open fireattack opened 8 months ago

fireattack commented 8 months ago

Describe the bug The durations are in seconds (s), not "m".

To Reproduce Steps to reproduce the behavior:

  1. Go to Editor -> Statistics
  2. Check toolbar

Expected behavior A clear and concise description of what you expected to happen.

Screenshots

bug

Desktop (please complete the following information):

NickeManarin commented 7 months ago

It's read as 0 minutes, 0 seconds, 50 miliseconds, and since I'm showing the minutes part, the label it's shown as "m".

I can change to reduce the minimum level to seconds (when less than 1 minute), then it will display as: 00.050 s

fireattack commented 7 months ago

Thanks for explanation!

I'd argue even if it's more than 1 minute, say, 2m5s, a notation of "02:05.000 m" is still weird, if not wrong (like you won't write 2h10m5s as "02:10:05.000 h").

Since it's just a standard timestamp format, and the inclusion of milliseconds makes it not ambiguous, maybe we can just remove the unit?

pawlos commented 7 months ago

Tbh, when I briefly looked at this in the code, to me it should also be w/o any unit