search

NickeManarin / ScreenToGif

🎬 ScreenToGif allows you to record a selected area of your screen, edit and save it as a gif or video.
http://www.screentogif.com
Microsoft Public License
23.6k stars 2.17k forks source link

[Feature] #1241 Do not automatically DOWNLOAD updates in metered networks #1252

Closed GopherTheCoder closed 8 months ago

GopherTheCoder commented 10 months ago

Hello @NickeManarin , I've tried to implement this feature requested in #1241 , but I changed it a bit. Instead of don't check for updates, I only constrained the automatic download of new version.

The method to check if is in metered networks comes from here: stackoverflow

But there brings a problem. The WinRT API I used was introduced after Windows 10, so I had to change the target OS version to 10.0.17763.0, which will likely make the product incompatible with old Windows version. I'm still trying to find a way to make it version adaptive, any advice would be appreciated. But for now I still want to create this PR for visibility.

Appreciate your time!

GopherTheCoder commented 9 months ago

Seems pre-Windows 10 support will be dropped by upgrading to .NET 8.0 .NET 8 - Supported OS versions So the compatibility issue seems gone. Merged to reflect the change.

NickeManarin commented 9 months ago

Hello @GopherTheCoder ! Thank you for the help :)

Do I need to setup something on my end? Because it says that the namespace Windows.Networking.Connectivity doesn't exist.

NickeManarin commented 9 months ago

Oh okay... I just needed to target the correct OS version. I assumed that you done that.

image

NickeManarin commented 9 months ago

Do you mind resolving the conflicts and rebasing (dev)?

GopherTheCoder commented 9 months ago

Do you mind resolving the conflicts and rebasing (dev)?

Did the rebasing, not so familiar with Git, hope I did it right.

For the target OS version, I thought the minimum OS version will already be 10.0.17763.0 implictly, as target framework changed to .NET 8.0. Seems that's not the case, still need to explicitly specify that, I see you already did that in dev.

Sorry I didn't do a test last time, only merged in Github webUI. I gave it a try locally this time, everything looks good. Is there any proper testing for changes/PRs that I can do?

NickeManarin commented 8 months ago

Is there any proper testing for changes/PRs that I can do?

I'll do a test manually. Thank you. :)

GopherTheCoder commented 8 months ago

Hooray to my first ever open source code contribution!