NickeManarin / ScreenToGif

🎬 ScreenToGif allows you to record a selected area of your screen, edit and save it as a gif or video.
http://www.screentogif.com
Microsoft Public License
23.04k stars 2.15k forks source link

The green fades when resizing a custom area are missleading #692

Open timunie opened 3 years ago

timunie commented 3 years ago

The "Problem"

If one wants to resize the rectangle to capture by mouse the recorder opens a magnifier with a green cross / fade to show the actual mouse position. This is very useful to catch the exact pixel. The problem here is, that the green fade shows the mouse position, and not the corner of the rectangle.

image

A possible solution

P.S.: I wanted to take a gif, but this didn't work. I hope one can understand my idea.

Happy coding Tim

NickeManarin commented 3 years ago

Hi Tim,

The green crosshair and the mouse cursor are in sync with the selection rectangle. So, the landing pixels of the green crosshair, is same landing pixels of the selection rectangle, and the capture will have an offset of 1 pixel (in each side).

In this example, the line is in the middle of 1 pixel, so the distance from the selection to the white pixel is 1 pixel. Green crosshair -> 1 dark pixel -> white pixels image

Here's the result, 1 pixel thick dark border in the top/left sides. image

The capture has too 1 pixel thick dark border to the top/left. image

I'm going to see how I can improve the UX of that magnifier.

timunie commented 3 years ago

Wow what a fast answer.😲 Your image is exactly what I am loooking for but it didn't work kn my mashine. I will doublecheck this tomorrow if there is any setting or if I missed an update.

timunie commented 3 years ago

Hi @NickeManarin I know double-checked my version and it is up to date.

  1. Here is my magnifier when dragging the resizing thumb. The green cross is exactly on the border i like: image Are you with me, that the selection rectangle should start on the gray border?

  2. And here is the result when releasing the mouse button (I tried it several times to be sure I didn't move the mouse by accident): image

  3. If I capture, my image is cutted: image

Note: I am running Windows 7, so if it is related to Win7 I will close this issue. Win7 is not supported by MS today, so you don't need to.

Anyway ScreenToGif is the best screen recorder I found :+1:

NickeManarin commented 3 years ago

Your selection in the first image is a few pixels to the side...

timunie commented 3 years ago

You are right, that I grabbed the dragging thumb on the outer corner for demonstration purpose. But this may be what the normal user also does. I can fairly live with it, but wanted to give back something, at least if I have an improvement idea share it. If you like to stick with the current implementation, it is fine. Then just close the issue. If you want me to have a look if I can make a PR, just give me a for doing it.

NickeManarin commented 3 years ago

Ahh, so the problem is the user experience after the first drag-to-select (when the user is dragging the little squares), right?

byzod commented 3 years ago

Can confirm

This is an example image, I want to capture pixel inside the red rectangle (including red rectangle itself) t2z

So this is how I select it (it's correct, right?) t2-s1 t2-s2

Then I got this in editor t2-s3

The upper left corner works as expected but lost one row and column at bottom right corner

NickeManarin commented 3 years ago

@byzod I believe this was fixed with v2.27.

byzod commented 3 years ago

No, and it don't allow me to select small area now

A1