search

Nickersoft / push.js

The world's most versatile desktop notifications framework :earth_americas:
https://pushjs.org
MIT License
8.77k stars 548 forks source link

Add type overload for Push.Permission.request() #244

Closed Jicmou closed 1 year ago

Jicmou commented 4 years ago

Fixes #243

theLufenk commented 4 years ago

@Jicmou Thank you for this. There seems to be a test failing. Can you look into it please.

@Nickersoft LGTM. Can be merged.

Jicmou commented 4 years ago

@theLufenk Thanks for approving.

I can reproduce the failing CI on master. Run the following commands:

npm run test
// passing
npm run build
// builds sucessfully
npm run test
// failing

I ran the first two commands before commiting, as stated in the CONTRIBUTING.md, Travis ran the third.

I could submit my PR without the build though, as index.d.tshas no impact on the build.

theLufenk commented 4 years ago

@Nickersoft Over to you.

theLufenk commented 4 years ago

nudge @Nickersoft