search

Nickersoft / push.js

The world's most versatile desktop notifications framework :earth_americas:
https://pushjs.org
MIT License
8.76k stars 548 forks source link

fix(types) change vibrate to a number array #274

Open rob4226 opened 3 years ago

rob4226 commented 3 years ago

Currently, the typescript type definition shows that vibrate is a boolean but per the docs it should be a number array:

An array of durations for a mobile device receiving the notification to vibrate. For example, [200, 100] would vibrate first for 200 milliseconds, pause, then continue for 100 milliseconds. For more information, see below. Available in Mobile Chrome only. https://pushjs.org/docs/options

Note: I only wanted to change index.d.ts and src/types.js but it looks like the precommit script forces a build anyway so not sure what changed in the other files. Thanks.