Why are Guzzle http_errors disabled?

NicklasWallgren / PokemonGoAPI-PHP

Pokemon Go API PHP library

BSD 2-Clause "Simplified" License

130 stars 51 forks source link

Open DrDelay opened 8 years ago

DrDelay commented 8 years ago

I asked this here and decided to open an own issue for it.

They are set to false in the Client and RequestHandler.

I don't really see the reason, especially since the behavior got basically re-implemented in 01cb790735c62e9f9c49f5c8da9f63910ab77590.

Ni42 commented 8 years ago

Oh, yeah, the nicer way would be to let Guzzle throw them instead of doing that status code check :)

NicklasWallgren commented 8 years ago

Old habits die hard I guess ;) No real reason really, better readability maybe.

DrDelay commented 8 years ago

To inspect/debug errors (e.g. #105) it would be more useful to just let Guzzle handle it I think.

So if there is no real reason why not I'll start looking for what would have to change (removing the then-redundant self-implemented checks).