Closed mattwells closed 8 years ago
Thanks, I wasn't aware of that. Can you also update the getMaxCp method to reflect on the changes? :)
$maxCpMultplier = self::$LEVEL_TO_CP_MULTIPLIER[40.0];
Done
It doesn’t matter, if it looks like an integer it will be treated as an integer so 40 == '40'
. You can see it in the after part of my pull request message, notice that all the integers are integers but the floats are strings. If you feel it is necessary I will do it later
Thanks for the contribution :)
Floats have been used as keys in the
CombatPointsCalculator::$LEVEL_TO_CP_MULTIPLIER
array. Floats aren't supported as array keys:You can see the difference in the
var_dump
before and after the change:After: