search

NicklasWallgren / PokemonGoAPI-PHP

Pokemon Go API PHP library
BSD 2-Clause "Simplified" License
130 stars 51 forks source link

With 0.37 version, this API won't work anymore #142

Closed paoloalby closed 7 years ago

paoloalby commented 7 years ago

@DrDelay in the last days, the login using Google Auth Token doesn't work anymore. For 2 months everything ok, but since saturday it seems something changed. What changed? If files are always the same, I supposed that Niantic changed something. Maybe the url to request the token is different now. Can you check, please?

PS: PTC login still works, of course.

Raphaelbm commented 7 years ago

Yes now is same for me ^^ but still works for few people.

nekar93 commented 7 years ago

Same problem for me. I can't use google's login function.

guirreri commented 7 years ago

I'm getting the following error on one account, but not the I other - haven't logged in since Saturday for either.

When searching the issues for a similar error there is mention of a proxy, but that doesn't make sense if one is working on the same system, but not the other.

Fatal error: Uncaught Exception: Incorrect wire format for field 10, expected: 0 got: 2 in /Applications/MAMP/htdocs/PokemonGoAPI-PHP/vendor/nicklasw/pogoprotos-php/src/POGOProtos/Data/PokemonData.php:148

baskettcase commented 7 years ago

Yep same @NicklasWallgren

Uncaught exception 'Exception' with message 'Incorrect wire format for field 1, expected: 0 got: 2' in /home/username/public_html/vendor/nicklasw/pogoprotos-php/src/POGOProtos/Inventory/InventoryDelta.php:36

voxx commented 7 years ago

Having same/similar error as well, however this does not appear to be related to google login or ptc login, or login at all for that matter. Login functionality works fine with both account types for me.

I was able to reproduce this issue on any account that has upgraded to latest version and set a "buddy". Upon doing so it appears the protos begin to fail and no longer mesh with the data being returned by the server for pokemon.

Accounts which have not updated and selected a "buddy" appear to work fine however. This again points to proto not meshing with actual returned data.

Havent had a chance to dig into it much, but I think we're going to need some refactoring to protos to account for the additional attributes the "buddy" functionality adds to the response.

Error and stack trace to add to the list.

Fatal error: Uncaught Exception: Incorrect wire format for field 19, expected: 0 got: 3 in /private/var/www/vhosts/pgoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/POGOProtos/Data/PokemonData.php:220 Stack trace: #0 /private/var/www/vhosts/pgoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/protocolbuffers.inc.php(84): POGOProtos\Data\PokemonData->read(Resource id #161, 3) #1 /private/var/www/vhosts/pgoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/POGOProtos/Data/PokemonData.php(50): ProtobufMessage->construct(Resource id #161, 3) #2 /private/var/www/vhosts/pgoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/POGOProtos/Inventory/InventoryItemData.php(48): POGOProtos\Data\PokemonData->construct(Resource id #161, 3) #3 /private/var/www/vhosts/pgoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/protocolbuffers.inc.php(84): POGOProtos\Inventory\InventoryItemData->read(Resource id #161, 0) #4 /private/var/www/vhosts/pgoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/POGOProtos/Inventory/InventoryItemData in /private/var/www/vhosts/pgoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/POGOProtos/Data/PokemonData.php on line 220

paoloalby commented 7 years ago

@NicklasWallgren and @DrDelay can you help us?

Ni42 commented 7 years ago

If the problem is in fact only happening to accounts that logged in on the new app version (buddy pokemon), that will not be easy. The PHP API only supports v0.35, because starting with 0.37 new authentication is required which is not as easy to emulate and the server will not allow you to downgrade so easily.

If the problem also happens on other accounts that were never used on v0.37, that's different...

voxx commented 7 years ago

From my limited testing it only appears to be affecting v0.37 accounts that have selected a buddy to follow them. I have tested a v0.37 account that upgraded game client, but did not yet select a pokemon buddy and everything appears fine. I can auth and pull back player and bag data for that account.

It's does not appear to be the auth portion that is choking, it's crapping out when you have chosen a buddy to follow you, and then attempt to retrieve pokemon / player data. The defined proto schema no longer matches what is returned by the server so it can't parse the response properly after the additional player and poke attributes are added related to the buddy selection and distance walked.

guirreri commented 7 years ago

Agreed with @voxx - issue also definitely does not happen on my secondary account which has not had the app upgrade. @voxx's analysis of simply a mismatched schema also seems correct in my testing (at "field 10") - the login with google is fine.

Raphaelbm commented 7 years ago

Maybe can help you: https://support.pokemongo.nianticlabs.com/hc/en-us/articles/222648408-Permissions-update

Ni42 commented 7 years ago

The thing with changing the schema is that there is currently no functionality to decide which version of the Protos to use, so we're not yet updated to 0.37. I'm not sure if we could even officially declare us as 0.37 on Niantics server, since that would likely require us to supply the additional auth...

NicklasWallgren commented 7 years ago

I haven't been able to reproduce this issue as of yet. As stated above, the problem(s) are probably due to the latest API changes.

Raphaelbm commented 7 years ago

Someone knows how to solve this error ? I really need to solve this ^^

Ni42 commented 7 years ago

What's stopping you from using PTC login? If you don't want to be banned you shouldn't use the API scripts with your main accounts anyways.

Raphaelbm commented 7 years ago

It's not the problem ! If we don't use API scripts with our principal account this API is useless I think. And there is no more risk to be ban now.

sedziwoj commented 7 years ago

Maybe add in README.md info it only works with 0.35 API? I want help, but I don't like work with bytes.

f2008305 commented 7 years ago

i tested on 2 accounts (both after logged in in 0.37 app) n°1 = PTC with buddy n°2 = PTC without buddy only the n°1 get this error: "Incorrect wire format for field 1, expected: 1 got: 0" the other one work perfectly without errors.

Ni42 commented 7 years ago

Yes, that's what we're saying. As soon as the Niantic server treats you as a 0.37 client, the data format changes and that's not covered by the current PHP API. Unlikely to change for the near future I think.

Vlakon commented 7 years ago

Will there be an update? As far as i know, all players have been forced to update to 0.37 now.

DrDelay commented 7 years ago

The upstream protos-repo does have some buddy-related changes that the PHP-protos used in this repo do not have.

E.g. buddy_candy_awarded - this is not in the current PokemonData.php

Or some of the buddy-related files here miss completely.

Update the protos and we have a good chance it'll work again. I would do it, but am having problems with the bramp-compiler (can you do that @NicklasWallgren ?). These PHP-protos are up to date by the way 😆.

CC #145 #147

NicklasWallgren commented 7 years ago

The files has been updated. Have a look.

Raphaelbm commented 7 years ago

We juste have to pull and composer update ?

nickpoulos commented 7 years ago

Where are the latest 'buddy' protos? I can attempt to recompile for PHP

voxx commented 7 years ago

@NicklasWallgren

I've pulled the latest changes to pogoprotos-php and pokemongoapi-php and am still getting proto related errors when attempting to pull inventory. Appears there is still some issues parsing the inventory data.

Fatal error: Uncaught Exception: Incorrect wire format for field 10, expected: 0 got: 6 in /private/var/www/vhosts/pokemongoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/POGOProtos/Data/PokemonData.php:149 Stack trace: #0 /private/var/www/vhosts/pokemongoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/protocolbuffers.inc.php(84): POGOProtos\Data\PokemonData->read(Resource id #150, 2) #1 /private/var/www/vhosts/pokemongoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/POGOProtos/Data/PokemonData.php(51): ProtobufMessage->construct(Resource id #150, 2) #2 /private/var/www/vhosts/pokemongoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/POGOProtos/Inventory/InventoryItemData.php(48): POGOProtos\Data\PokemonData->construct(Resource id #150, 2) #3 /private/var/www/vhosts/pokemongoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/protocolbuffers.inc.php(84): POGOProtos\Inventory\InventoryItemData->read(Resource id #150, 0) #4 /private/var/www/vhosts/pokemongoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/PO in /private/var/www/vhosts/pokemongoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/POGOProtos/Data/PokemonData.php on line 149

NicklasWallgren commented 7 years ago

The current proto files are obviously outdated.

It would be really helpful If anyone could provided me with an test account that experience these issues.

Raphaelbm commented 7 years ago

im here if you need my help

nickpoulos commented 7 years ago

I just read the latest buddy protos are around somewhere, hold on I gotta find where I read it.

On Wed, Sep 28, 2016 at 10:38 AM, Raphaelbm notifications@github.com wrote:

im here if you need my help

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NicklasWallgren/PokemonGoAPI-PHP/issues/142#issuecomment-250185773, or mute the thread https://github.com/notifications/unsubscribe-auth/ADxq6bEAmHwGDdpA469chjR8Pu17z330ks5qunvMgaJpZM4J7VUf .

Nick Poulos Lead PHP Engineer Check Out LittleThings.com http://littlethings.com/

DrDelay commented 7 years ago

This is the only PoGo-protos-repo I know of: https://github.com/AeonLucid/POGOProtos

Last commit is 28 days ago though, if you know of another one with the current changes that would be much appreciated.

nickpoulos commented 7 years ago

yea i gotta look still, sorry today is deploy day at work, travis-ci kept fucking up tagging our builds red, but i got a few min now lemme find what i saw

On Wed, Sep 28, 2016 at 12:57 PM, DrDelay notifications@github.com wrote:

This is the only PoGo-protos-repo I know of: https://github.com/AeonLucid/ POGOProtos

Last commit is 28 days ago though, if you know of another one with the current changes that would be much appreciated.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NicklasWallgren/PokemonGoAPI-PHP/issues/142#issuecomment-250228781, or mute the thread https://github.com/notifications/unsubscribe-auth/ADxq6akWTebartkwHLbK493i779Qg44nks5qupyIgaJpZM4J7VUf .

Nick Poulos Lead PHP Engineer Check Out LittleThings.com http://littlethings.com/

nickpoulos commented 7 years ago

Fuck man I was wrong, lol it was your msg I read that said the upstream ones have buddy changes that this PHP version doesnt. Was this buddy stuff even Pokemon Go 28 days ago? How do all these guys doing those bullshit python bots still able to login, I am about to pull theirs and see.

https://github.com/PokemonGoF/PokemonGo-Bot

On Wed, Sep 28, 2016 at 3:28 PM, Nick Poulos nick@littlethings.com wrote:

yea i gotta look still, sorry today is deploy day at work, travis-ci kept fucking up tagging our builds red, but i got a few min now lemme find what i saw

On Wed, Sep 28, 2016 at 12:57 PM, DrDelay notifications@github.com wrote:

This is the only PoGo-protos-repo I know of: https://github.com/AeonLucid/POGOProtos

Last commit is 28 days ago though, if you know of another one with the current changes that would be much appreciated.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NicklasWallgren/PokemonGoAPI-PHP/issues/142#issuecomment-250228781, or mute the thread https://github.com/notifications/unsubscribe-auth/ADxq6akWTebartkwHLbK493i779Qg44nks5qupyIgaJpZM4J7VUf .

Nick Poulos Lead PHP Engineer Check Out LittleThings.com http://littlethings.com/

Nick Poulos Lead PHP Engineer Check Out LittleThings.com http://littlethings.com/

voxx commented 7 years ago

@NicklasWallgren

I did a bit more testing tonight and determined that simply adding a buddy itself doesn't cause the problem.

I created a new account (0.39.0) added buddy, and tested with a fresh pull of the repo and I was able to pull player profile, and pokebank just fine. No authentication issues, no errors, protos work fine against returned data from api.

I then proceeded to walk the buddy until it earned a candy (3km) and tested again. Now the pokebank pull fails. Protos no longer matches data returned due to the extra params the buddy pokemon earning a candy added.

Fatal error: Uncaught Exception: Incorrect wire format for field 1, expected: 1 got: 0 in /private/var/www/vhosts/pokemongoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/POGOProtos/Data/PokemonData.php:64 Stack trace: #0 /private/var/www/vhosts/pokemongoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/protocolbuffers.inc.php(84): POGOProtos\Data\PokemonData->read(Resource id #150, 1) #1 /private/var/www/vhosts/pokemongoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/POGOProtos/Data/PokemonData.php(51): ProtobufMessage->construct(Resource id #150, 1) #2 /private/var/www/vhosts/pokemongoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/POGOProtos/Inventory/InventoryItemData.php(48): POGOProtos\Data\PokemonData->construct(Resource id #150, 1) #3 /private/var/www/vhosts/pokemongoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/protocolbuffers.inc.php(84): POGOProtos\Inventory\InventoryItemData->read(Resource id #150, 0) #4 /private/var/www/vhosts/pokemongoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/POGO in /private/var/www/vhosts/pokemongoapi-php/wwwroot/vendor/nicklasw/pogoprotos-php/src/POGOProtos/Data/PokemonData.php on line 64

I can provide you with the credentials to this account for testing to reproduce the issue if you'd like. Send me a message.

DrDelay commented 7 years ago

You could attach the (raw) protobuf message that leads to the error here. I'd be interested in testing this aswell as other I suppose, but giving everyone the account credentials is not the way to go.

A (temporary) file_put_contents here - saving $response->getBody()->getContents() - should do.

We could do a protoc --decode_raw on the message and compare it against the schema in PokemonData.proto.

voxx commented 7 years ago

@DrDelay

Hey, as requested I've added the line to dump the raw response to RequestHandler.php on line 280

    file_put_contents( dirname(__FILE__).'/raw-response.txt', $response->getBody()->getContents());

Here is the raw response for decoding.

raw-response.txt

I'm not familiar with protoc --decode_raw functionality, but I'd be happy to help you guys with dumps and anything else you need to help fix the protos.

-VoxX

Ni42 commented 7 years ago

You can just use protoc --decode_raw < inputFileName.txt and it should output a structured representation of the file. The protoc (de)compiler can be found here: https://github.com/google/protobuf/releases

Use the 3.0.2 version for now, I just noticed they finally have 3.1 with PHP support out. * _ *

DrDelay commented 7 years ago

Thank you, but it seems like this is the login response:

1: 53
2: 738472893
3: "pgorelease.nianticlabs.com/plfe/7"
7 {
  1: "\3108\357\323\206\264I:z\361\306\021\372\313\270\273\204\354i$\023\230\022\317E\237.V@\215\0247\260\337\207S\376\277\330\313\332G\345Y\002\016\366A\353\212\204\013\337\017L\355\374\033\203S(s\010\207\243\007\2411yZ\357-\310H\304\306\177\010Y\253"
  2: 1475459895649
  3: "\364\330\377=G^\243U\231\312j\246\261\014\027\200"
}
100: ""

Can you try to save all requests? Using for example this approach you won't override them by each other:

file_put_contents(tempnam('/some/path', 'pogoprotodump'), $response->getBody()->getContents())
voxx commented 7 years ago

//RequestHandler.php Debug Logic (Line 280) file_put_contents(tempnam('/private/tmp/', 'pogoprotodump').'.txt', $response->getBody()->getContents());

//API Code Executed $pokeBank = $pokemonGoApi->getInventory()->getpokeBank();

//Raw Encoded Response Dump (only 1 file was generated) pogoprotodump8eU6Ez.txt

//Decode using protoc protoc --decode_raw < /private/tmp/pogoprotodump8eU6Ez.txt

//Decoded output 1: 53 2: 821746005 3: "pgorelease.nianticlabs.com/plfe/416" 7 { 1: "\335 S\230\353\206\373\374&\026W\205W\231\356r\322FN\036\204%L\035\243:\\\177\256\\\252\013\004X\241\232pp&\254yW\341bv0i\371s@\272B\256\023Rb\221m\234]\326jm\300\223\007\265\tSC\030\222p\317\212\r\350\353\361Y" 2: 1475495404875 3: "&\264\263\314\214o\202\003#\276V\205\007s\202\241" } 100: ""

DrDelay commented 7 years ago

It should be more, this is only a handshake response without data.

I just downloaded PoGo (0.39.1) on my Android phone and selected a buddy on a (PTC) test account. As you already mentioned, I can still use this API until this point. This is how my buddy-"Glumanda"s protobuf looks:

          1: 0xf1715125345b3e7f
          2: 4
          3: 12
          4: 10
          5: 10
          6: 220
          7: 24
          15: 0x3f418dbe
          16: 0x4164efe7
          17: 10
          18: 10
          19: 10
          20: 0x3dc08312
          22: 5160791288669274112
          26: 1471772932211

field 32 "buddy_candy_awarded" is not yet even set at the moment.

I assume I have to walk for a while now to get some candy :laughing:.

voxx commented 7 years ago

Hmm, well not sure whats wrong then.

I've placed the debug/dump logic on line 280 in /src/Handlers/RequestHandler.php as you've indicated. (both variations).

Any ideas on why i'm only getting the login response and not the rest?

I am using Google account btw, not sure why that would make a difference, but I don't seem to be able to dump anything more than the login/handshake as you've indicated. I even tried moving the dump up the stack trace into the call function prior to unmarshell being called. Same output.

nickpoulos commented 7 years ago

Wow good work dude, interesting. So the message changes only after earning a candy with a buddy. Can we not guess or re-factor the message ourselves? I mean someone had to figure these out and make them in the first place, we gotta be able to also.

On Sun, Oct 2, 2016, 7:41 AM DrDelay notifications@github.com wrote:

You could attach the (raw) protobuf message that leads to the error here. I'd be interested in testing this aswell as other I suppose, but giving everyone the account credentials is not the way to go.

A (temporary) file_put_contents here https://github.com/NicklasWallgren/PokemonGoAPI-PHP/blob/d90e26ed5e94da9c92ce35eb67f4197eaa161ada/src/Handlers/RequestHandler.php#L280

  • saving $response->getBody()->getContents() - should do.

We could do a protoc --decode_raw on the message and compare it against the schema in PokemonData.proto https://github.com/AeonLucid/POGOProtos/blob/master/src/POGOProtos/Data/PokemonData.proto .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NicklasWallgren/PokemonGoAPI-PHP/issues/142#issuecomment-250967178, or mute the thread https://github.com/notifications/unsubscribe-auth/ADxq6ax5O_JNA8Jksh3TOmjvUdWLcp8xks5qv5h9gaJpZM4J7VUf .

DrDelay commented 7 years ago

@voxx was so nice to provide me with his test account, this is his Pokémon with 1 candy collected:

          1: 0x202b7a81cd7e388c
          2: 7
          3: 13
          4: 10
          5: 10
          6: 221
          7: 57
          15: 0x3f031d25
          16: 0x412663e6
          17: 10
          18: 10
          19: 10
          20: 0x3dc08312
          26: 1475152263159
          29: 1
          32: 1
          33: 0x40400000

There is indeed a field 33 that is not in the current proto definition. Yes, @nickpoulos, we'd have to find out what this is and add it to the schema. Adding it as unknown33 should be fairly easy, finding out what it IS good for requires some more thought.

The getPokeBank-responses I analyzed:

nickpoulos commented 7 years ago

Ahhh and there it is. Good shit guys, seriously. Now we need a way to figure out what unknown 33 actually does or means...what numbers come back in UK33 from a legit request?

On Mon, Oct 3, 2016 at 11:20 AM, DrDelay notifications@github.com wrote:

@voxx https://github.com/voxx was so nice to provide me with his test account, this is his Pokémon with 1 candy collected:

      1: 0x202b7a81cd7e388c
      2: 7
      3: 13
      4: 10
      5: 10
      6: 221
      7: 57
      15: 0x3f031d25
      16: 0x412663e6
      17: 10
      18: 10
      19: 10
      20: 0x3dc08312
      26: 1475152263159
      29: 1
      32: 1
      33: 0x40400000

There is indeed a field 33 that is not in the current proto definition https://github.com/AeonLucid/POGOProtos/blob/a01a480e461b3e2ef29f9f4de6c7af318025a321/src/POGOProtos/Data/PokemonData.proto. Yes, @nickpoulos https://github.com/nickpoulos, we'd have to find out what this is and add it to the schema. Adding it as unknown33 should be fairly easy, finding out what it IS good for requires some more thought.

The getPokeBank-responses I analyzed:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NicklasWallgren/PokemonGoAPI-PHP/issues/142#issuecomment-251135683, or mute the thread https://github.com/notifications/unsubscribe-auth/ADxq6dR1rDPSolcmF8TbzAa6fIaxU72Mks5qwR0pgaJpZM4J7VUf .

Nick Poulos Lead PHP Engineer Check Out LittleThings.com http://littlethings.com/

DrDelay commented 7 years ago

Fun fact: Decoding "withBuddyWithCandy" using jaspervdm/pogoprotos-php works, it seems to just ignore the data it has no fields for.

nickpoulos commented 7 years ago

Really? Interesting....so you are saying you can login using those with an account that does or doesnt have any buddy candy collected?

On Mon, Oct 3, 2016 at 11:36 AM, DrDelay notifications@github.com wrote:

Fun fact: Decoding "withBuddyWithCandy" using jaspervdm/pogoprotos-php https://github.com/jaspervdm/pogoprotos-php works, it seems to just ignore the data it has no fields for.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NicklasWallgren/PokemonGoAPI-PHP/issues/142#issuecomment-251140137, or mute the thread https://github.com/notifications/unsubscribe-auth/ADxq6VvO0716bGaJfmbzCp3zTjxRq8bwks5qwSDzgaJpZM4J7VUf .

Nick Poulos Lead PHP Engineer Check Out LittleThings.com http://littlethings.com/

DrDelay commented 7 years ago

The login works here aswell, it is the parsing of the GetInventoryResponse that fails. But yes, the other protobuf-php lib parses both responses correctly.

nickpoulos commented 7 years ago

I wonder where the other python bot guys stand on this stuff, if they have gotten this far. Couldn't we just take their protos and re-code the differences in php?

On Mon, Oct 3, 2016 at 11:53 AM, DrDelay notifications@github.com wrote:

The login works here aswell, it is the parsing of the GetInventoryResponse https://github.com/AeonLucid/POGOProtos/blob/master/src/POGOProtos/Networking/Responses/GetInventoryResponse.proto that fails. But yes, the other protobuf-php lib https://github.com/protobuf-php/protobuf parses both responses correctly.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NicklasWallgren/PokemonGoAPI-PHP/issues/142#issuecomment-251144964, or mute the thread https://github.com/notifications/unsubscribe-auth/ADxq6VAjuWinP51svmWeQ-IYoH_cIusgks5qwST_gaJpZM4J7VUf .

Nick Poulos Lead PHP Engineer Check Out LittleThings.com http://littlethings.com/

DrDelay commented 7 years ago

If the "python guys" also use a protobuf lib that just throws away surplus data (unlike ours) they might never have stumbled across this problem. I don't really believe they have different proto files, like already mentioned AeonLucid/POGOProtos is the only repo there is (that I know of).

nickpoulos commented 7 years ago

we have a slack/IRC channel anywhere? Google hangout even? Might make this easier to brainstorm and discuss ideas to get past this hurdle.

On Mon, Oct 3, 2016 at 11:59 AM, DrDelay notifications@github.com wrote:

If the "python guys" also use a protobuf lib that just throws away surplus data (unlike ours) they might never have stumbled across this problem. I don't really believe they have different proto files, like already mentioned AeonLucid/POGOProtos https://github.com/AeonLucid/POGOProtos is the only repo there is (that I know of).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NicklasWallgren/PokemonGoAPI-PHP/issues/142#issuecomment-251146638, or mute the thread https://github.com/notifications/unsubscribe-auth/ADxq6cyH_qsV2QVxL6zUfWjG9pU8-o1Tks5qwSZggaJpZM4J7VUf .

Nick Poulos Lead PHP Engineer Check Out LittleThings.com http://littlethings.com/

DrDelay commented 7 years ago

I wasted the last 1.5 hours trying to get the bramp protobuf compiler working but gave up now. My idea would be to add a UK33 optional float (?) field and see if this does the job.

No, there is no communication channel for this project yet, but I think there is one for the subreddit.

nickpoulos commented 7 years ago

I am at work its hard for me to get stuff done here, but my boss is actually out today. If I finish up a few tasks I can get a few hours in probably around 2pm. I can try compiling the protos myself I think I use a diff compiler. But yes I agree with you, even if we don't necessarily know what UK33 does, can't we just include it so that we aren't bombing out? Just leave an extra spot for a float.

On Mon, Oct 3, 2016 at 1:08 PM, DrDelay notifications@github.com wrote:

I wasted the last 1.5 hours trying to get the bramp protobuf compiler working but gave up now. My idea would be to add a UK33 optional float (?) field and see if this does the job.

No, there is no communication channel for this project yet, but I think there is one for the subreddit https://www.reddit.com/r/pokemongodev.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NicklasWallgren/PokemonGoAPI-PHP/issues/142#issuecomment-251164582, or mute the thread https://github.com/notifications/unsubscribe-auth/ADxq6Qv0jZJtBwMfAX0a6kS8TfYzoK1wks5qwTZ_gaJpZM4J7VUf .

Nick Poulos Lead PHP Engineer Check Out LittleThings.com http://littlethings.com/

NicklasWallgren commented 7 years ago

@Ni42 Great news, I'll dig into the Alpha release tomorrow :) https://github.com/google/protobuf/tree/3.1.x/php

@DrDelay What type of issues have you encountered?

The key issue is the PHPCodeGenerator::Generate method. 

cerr << "Generating " << php_filename << endl;

// Check if the file already has been compiled
if (std::find(listOfFiles.begin(), listOfFiles.end(), php_filename) != listOfFiles.end()) {
  cerr << "Skipping file, already compiled " << php_filename << endl;

  return true;
}

// Push the file to list of compiled files
listOfFiles.push_back(php_filename);

@voxx Bring me that account already ;) You can reach me at nicklas.wallgren@gmail.com.