search

NicklasWallgren / PokemonGoAPI-PHP

Pokemon Go API PHP library
BSD 2-Clause "Simplified" License
130 stars 51 forks source link

Update vendor/nicklasw/pkm-go-api/src/Api/Pokemon/Data/PokemonMetaRegistry.php #165

Closed xmillies closed 7 years ago

xmillies commented 7 years ago

The pokemon meta registry needs to be updated with new pokémons :

Notice: Undefined offset: 174 in C:\WTServer\WWW\pogo\vendor\nicklasw\pkm-go-api\src\Api\Pokemon\Data\PokemonMetaRegistry.php on line 26

Where do you take previous data ?

NicklasWallgren commented 7 years ago

@xmillies The information comes from the GAME_MASTER file https://gist.github.com/elfinlazz/5c7e33be1292329f61f1023a79251cc3

Anyone up for the task?

voxx commented 7 years ago

Here yah go.

Two attachments. 1) A script used to parse the json and output the relevant php. 2) The additional php objects to add to PokemonMetaRegistry.php

export-meta.php.txt

PokemonMetaRegistry.php.txt

NicklasWallgren commented 7 years ago

@voxx Nice addition 👍 Could you update the PokeMetaRegistry and make a pull request? :)

voxx commented 7 years ago

@NicklasWallgren PR created as requested.

-> https://github.com/NicklasWallgren/PokemonGoAPI-PHP/pull/168

NicklasWallgren commented 7 years ago

Resolved by @voxx

NicklasWallgren commented 7 years ago

Fixed a minor issue with suffixes.

https://github.com/NicklasWallgren/PokemonGoAPI-PHP/commit/2e955389cae3269584282f8283a683f6eb3b5bfe