NicklasWallgren / PokemonGoAPI-PHP

Pokemon Go API PHP library
BSD 2-Clause "Simplified" License
130 stars 51 forks source link

When retrieving pokedex new baby eggs are missing #171

Closed xmillies closed 7 years ago

xmillies commented 7 years ago

When retrieving pokedex new baby eggs are missing. For instance 240.

// Retrieve the pokedex
$pokedex = $inventory->getPokedex();
$pokedexItems= $pokedex->getItems();

var_dump(pokedexItems);

The last pokemon in Pokedex is not 151 ... but 240.

A small and usefull code to include ?


class pg
{
// available pokemons
    const AVAILABLE_POKEMONS = array(
        1, 2, 3, 4, 5, 6, 7, 8, 9, 10,
        11, 12, 13, 14, 15, 16, 17, 18, 19, 20,
        21, 22, 23, 24, 25, 26, 27, 28, 29, 30,
        31, 32, 33, 34, 35, 36, 37, 38, 39, 40,
        41, 42, 43, 44, 45, 46, 47, 48, 49, 50,
        51, 52, 53, 54, 55, 56, 57, 58, 59, 60,
        61, 62, 63, 64, 65, 66, 67, 68, 69, 70,
        71, 72, 73, 74, 75, 76, 77, 78, 79, 80,
        81, 82, 83, 84, 85, 86, 87, 88, 89, 90,
        91, 92, 93, 94, 95, 96, 97, 98, 99, 100,
        101, 102, 103, 104, 105, 106, 107, 108, 109, 110,
        111, 112, 113, 114, 115, 116, 117, 118, 119, 120,
        121, 122, 123, 124, 125, 126, 127, 128, 129, 130,
        131, 132, 133, 134, 135, 136, 137, 138, 139, 140,
        141, 142, 143, 144, 145, 146, 147, 148, 149, 150,
        151,
        // Pokemons Baby form 2th generation  Pokemon Go
        172, // Pichu
        173, // Cleffa (Mélo)
        174, // Igglybuff (Toudoudou)
        175, // Togepi
        // 236; // Tyrogue (Débugant)
        238, // Smoochum    (Lippouti)
        239, // Élekid
        240, // Magby
    );
} ```

Usage : 
```foreach (pg::AVAILABLE_POKEMONS as $i) {
     // your code here 
}```
NicklasWallgren commented 7 years ago

The pokedex only includes pokemon you have encountered in game. The PokemonMetaRegistry includes all pokemon, even the new onces.

DrDelay commented 7 years ago

What in fact is outdated is this example: https://github.com/NicklasWallgren/PokemonGoAPI-PHP/blob/2e955389cae3269584282f8283a683f6eb3b5bfe/examples/RetrievePlayerPokedexExample.php#L39

I think this should be completely replaced by something like

foreach ($pokedex->getItems() as $pokedexEntry) {
  // Not sure it's getId()
  $pokemonmeta = PokemonMetaRegistry::getByPokemonId($pokedexEntry->getId());
  echo sprintf("We know Pokemon %d. Name: %s \n", $pokedexEntry->getId(), $pokemonmeta->getuniqueId());
}

instead of using a for-loop; to eliminate hardcoding the Pokémon count that will likely increase again.