Remove println in response decoding

NicklasWallgren / ewelink

Ewelink SDK to control your eWelink smart devices.

MIT License

6 stars 8 forks source link

Remove println in response decoding #4

Closed ant1eicher closed 1 year ago

ant1eicher commented 1 year ago

Each call to the library results in the entire json response object being outputted to stdout. In order to get around this I have to temporarily reassign os.Stdout to nil, call the command, then reassign os.Stdout.

If this response log output is required, perhaps it would be better to use a logger with 'debug' or accept a verbose parameter?

(btw nice library, thanks :)

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4526808083

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 56.958%

Totals
Change from base Build 3698258076:	-0.1%
Covered Lines:	352
Relevant Lines:	618

💛 - Coveralls

NicklasWallgren commented 1 year ago

I must have left it there by mistake.

Thanks for the contribution!

ant1eicher commented 1 year ago

Cool man. Happy to help!

On Mon, 27 Mar 2023 at 12:57, NicklasWallgren @.***> wrote:

I must have left it there by mistake.

Thanks for the contribution!

— Reply to this email directly, view it on GitHub https://github.com/NicklasWallgren/ewelink/pull/4#issuecomment-1484934064, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6O4GHTC3LLTAUTKYLV4LDW6FXDDANCNFSM6AAAAAAWINPO7Y . You are receiving this because you authored the thread.Message ID: @.***>