Bot wont accept item overpay even if that item is listed in pricelist (with intent=sell)

[idinium96]

Your issue may already be reported! N/A

Describe the bug The bot will say it received an offer with an OVERSTOCKED (is taking/offering too many, declining...) item, although the item(s) they offered on their side is listed in pricelist (so it's priced) with intent=sell and max=10 (which perhaps the bot will accept it because it is not in the INVALIDITEMS (contains items we are not trading (not in pricelist), declining...)_ category.

To Reproduce

Steps to reproduce the behavior:

1. Add a weapon for the bot to bank (that the bot have, or you deposit it): (Huntsman) - !add sku=56;6&min=0&max=1&sell.metal=0.11&buy.metal=0.05&intent=bank
2. Add an item with a higher value than a weapon that the bot sell and set it intent to sell: (Professional's Panama) - !add sku=109;6&min=0&max=10&intent=sell
3. Using another account (not admin), buy (1. - Hunstman) from the bot using (2. - Profesional Panama).
4. See error/log

Expected behavior

The bot will decline the offer with OVERSTOCKED error.

Screenshots and logs

Overstocked_log.txt pricelist.json for PP

Additional context

I'm using non-released version (review-offers), that's why I can see the error, but I'm sure the latest version (v3.3.8) also have this problem. Also, I've tried adding this line of code to InventoryManager.ts, but it doesn't seem to be working at all. InventoryManager.ts_overstocked_try

Version: non-released (review-offers branch - v3.2.1) and latest v3.3.8.

[Nicklason]

Can you test it on the latest release?

[Nicklason]

Also the steps to reproduce the error are hard to understand. It is a lot "this and that". Just add the steps with a clear description for each step.

[idinium96]

Also the steps to reproduce the error are hard to understand. It is a lot "this and that". Just add the steps with a clear description for each step.

Noted.

Can you test it on the latest release?

Maybe others can help. If not, I'll send my logs later.

[idinium96]

Latest v.3.3.8: https://justpaste.it/log-latestv3-3-8-itemoverpay

I'm using the same pricelist as the review-offers version, which the Huntsman is intent=bank&min=0&max=100 and that Non-Craftable Profesional's Panama is intent=sell&min=0&max=10

---

This is what it looks like if I send !trade #tradenum to the review-offers version (just change in the Asked: to 0.11 ref (Huntsman):

Offer-reviews version (v3.2.1): itemoverpay2_review-offers

[idinium96]

Here, another case. Since the weapons that this guy put is in the price list will intent=sell, it's been categorized as OVERSTOCKED:

[idinium96]

Even if the value were not matched, if their side contains any items that in our pricelist with intent=sell (in this case, (1) Non-Craftable Bushwacka and (2) Thermal Thruster), it also categorized as OVERSTOCKED (not INVALID_VALUE or INVALID_ITEMS):

1. Should be INVALID_VALUE:
2. Should be INVALID_ITEMS (That Spruce Deuce Scattergun (BS) is not in the pricelist):

[idinium96]

Hurmm.. looks like no possible solution about this?

[Nicklason]

Hurmm.. looks like no possible solution about this?

Nah, I just haven't looked into it.

[CSM2]

Overpay is enabled, pricelist is set up, even with max=20 and 0 in stock the item overpay still gets declined as "Overstocked". Version 3.3.10

[idinium96]

(I am keeping the issue from being labeled as stale...)

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.