search

Nicklason / tf2-automatic

A free and open source, fully automated TF2 trading bot, advertising on backpack.tf using prices from prices.tf
https://tf2automatic.com
MIT License
82 stars 41 forks source link

Bot does not retry to accept offer after encountered an error #437

Closed idinium96 closed 4 years ago

idinium96 commented 4 years ago

Describe the bug My bot received an offer and then it encountered an error (28 - Already redeemed) and does not retry to accept it. The offer was received at 2020-04-29T18:41:07.675Z and luckily the trade partner was someone with high patient and did not cancel the trade until I realized it at 2020-04-30T00:20:33.651Z (about 6+ hours), which I manually accept the trade and do the confirmation using my SDA. It seems that the trade was recorded in polldata as 'active' but it just ignores it, restarting the bot won't help either.

To Reproduce Steps to reproduce the behavior: No known steps to reproduce an error.

Expected behavior The bot should retry to accept the offer, even after the bot was restarted because that offer is still 'active' in polldata and it's not an invalid offer.

Screenshots and logs Search for Offer ID #4020328414 in this log: Nezuko-2020-04-30.log

Additional context N/A

Version: v3.5.2 (customized - but not related to this)

viggojonasson commented 4 years ago

28 means that its already accepted.

idinium96 commented 4 years ago

Yes, but the trade is still active at that moment. Please take a look at the log and search for the offer ID that I've mentioned. Search it until there's no more of that offer ID.

idinium96 commented 4 years ago

Another scenario (highlighted green) queue and ignored trade.docx

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.