search

NickleDave / visual-search-nets

neural network models of visual search behavior
BSD 3-Clause "New" or "Revised" License
6 stars 2 forks source link

searchnets.tensorboard.logdir2csv duplicates path, causing FileNotFoundError #81

Closed NickleDave closed 3 years ago

NickleDave commented 3 years ago

when logdir2csv is called outside of the log directory, it causes a bug that doesn't get triggered when logdir is the current working directory

this is because the path for final filename generated gets duplicated: https://github.com/NickleDave/visual-search-nets/blob/2248c341635908994a11491df34f534501766eb8/src/searchnets/tensorboard.py#L80

    csv_path = events_file.parent.joinpath(events_file.stem + '.csv')
    df.to_csv(logdir.joinpath(csv_path))

it should instead be something like

    csv_path = events_file.stem + '.csv'
    df.to_csv(logdir.joinpath(csv_path))