Aura + CLI - Githubissues

NickvisionApps / Cavalier

Visualize audio with CAVA

MIT License

156 stars 8 forks source link

Aura + CLI #50

Closed fsobolev closed 1 year ago

fsobolev commented 1 year ago

Commits got messed on another branch so I created new one and copied everything in one commit.

There are still things to do, so it's a draft for now.

Notes:

CLI option that accept boolean value require explicit value, just -f will not work for example, needs -f true. It is possible to make "flags" using CommandLine, but they work as 2 state switches: true or false, with one of them being default. Here we actually need 3 states: do not change, change to true and change to false, that's why explicit value is required.
I use separate CmdOptions instead of Configuration because: a) options should be nullable so I can check whether they were used in command or not; b) not all configuration values should be exposed as command; c) some options have different types/values (like roundness which is 0-100 int in command but 0.0-1.0 float in configuration).

Closes #44

fsobolev commented 1 year ago

If the user starts the first instance of Cavalier with --help option or with any option that contains error, help will be printed to console and the app will not start. If the same is done while Cavalier is already running, this dialog will appear.

fsobolev commented 1 year ago

Rarely, but still sometimes CAVA wasn't stopping together with the app, latest commit will hopefully fix it. From the docs:

The Kill method executes asynchronously. After calling the Kill method, call the WaitForExit method to wait for the process to exit

I'm going to update changelog and then the PR is ready for review. Depends on https://github.com/NickvisionApps/Aura/pull/4 but other than saving config everything works.

EDIT: flatpak will obviously fail, I will update nuget-sources after fixed Aura release

nlogozzo commented 1 year ago

The scroll window inside a MessageDialog looks weird IMO...could you make it like the style of the CorruptedFilesDialog/HistoryDialog?

fsobolev commented 1 year ago

The scroll window inside a MessageDialog looks weird IMO...could you make it like the style of the CorruptedFilesDialog/HistoryDialog?

nlogozzo commented 1 year ago

The scroll window inside a MessageDialog looks weird IMO...could you make it like the style of the CorruptedFilesDialog/HistoryDialog?

Beautiful! Since there's no description however, maybe we don't need to have the scroll window with the view background...

fsobolev commented 1 year ago

Since there's no description however, maybe we don't need to have the scroll window with the view background...

But we still have heading and empty headerbar that don't scroll and should not. IMO this dialog template works good even without description. Plus darker background of scrolled window gives better contrast for text, so it's easier to read (at least with dark theme).