jannuary commented 2 years ago

List

The list view is odd. I don't think you can use a boxed list here, so it would make sense to simply remove the broken background.
Similarly, the scrollbar isn't on the edge of the window.
The list isn't clamped, so it's a bit silly on large window sizes. Use AdwClamp or AdwClampScrollable.

Tag Editor

There's no separator between the list and the editor pane.
Just like the List, this has margins on the scrolled view, so the scrollbar is floating and the list scrolls into nothingness.
I can't seem to navigate with the keyboard to the editor?
Some of these fields are not editable without any indication.

Headerbar

Some icons are missing.
"Save" and "Remove" buttons should probably be on the righthand side.
I'm not sure if "Filename to Tag" and "Tag to Filename" make sense as icon-only or buttons on the headerbar at all.

Primary Menu

The tooltip is "Help"?
"Github Repo", "Report a Bug" and "Changelog" are redundant - the about dialog already links to the repo.

nlogozzo commented 2 years ago

I will definitely fix the scroll bars of the list view and tag editor for the next release.

As far as There's no separator between the list and the editor pane. I thought the color contrast from the ListView would be separation enough but I'd be happy to add in a separator.

For Some of these fields are not editable without any indication. I mean the only fields not editable would be Duration and File Size because I think it's obvious you can't manually change a song's duration and/or file size.

For Some icons are missing. my fault as I'm using papirus-icon-theme . I will change to adwaita theme and choose the appropriate icon names

For I'm not sure if "Filename to Tag" and "Tag to Filename" make sense as icon-only or buttons on the headerbar at all. In the next release I'm planning to hide all these buttons in the header bar and only show them when items in the ListView are selected

For The tooltip is "Help"? I'll remove the tooltip

For "Github Repo", "Report a Bug" and "Changelog" are redundant - the about dialog already links to the repo. Yeah you're right. I think i'm going to keep "Changelog" but "GitHub Repo" and "Report a Bug" I will remove in favor of the link in the about dialog.

jannuary commented 2 years ago

For The tooltip is "Help"? I'll remove the tooltip

It should be "Main Menu", as per HIG :)

nlogozzo commented 2 years ago

Ah even better :)

nlogozzo commented 2 years ago

Coming in next release. You can build from 2022.5.3 branch to test out.

Files Not Selected: Files Selected:

nlogozzo commented 2 years ago

Light Theme:

nlogozzo commented 2 years ago

And with Adwaita icons this time xD

nlogozzo commented 2 years ago

New Design!

Save Tag has been renamed to Apply and placed on the right
The icon next to the Apply button is a submenu that contains actions such as Remove Tag, Filename to Tag, Tag to Filename, and Download Metadata
All actions bounded by keyboard shortcuts