NickvisionApps / Tagger

Tag your music
https://flathub.org/apps/details/org.nickvision.tagger
MIT License
219 stars 14 forks source link

Cannot drag and drop folders or files #354

Closed AbrarSL closed 8 months ago

AbrarSL commented 11 months ago

(NickvisionTagger.GNOME:2): Gtk-WARNING **: 10:11:14.226: Failed to receive drop data: Could not convert data from application/vnd.portal.filetransfer to GFile

This is what I get on the terminal when I attempt to drag a folder onto the app. I'm using the latest stable version from flathub.

There were some older issues regarding this but the problem still persists. The linked GTK issues on those old issues seem to have been resolved as well.

fsobolev commented 11 months ago

There were some older issues regarding this but the problem still persists. The linked GTK issues on those old issues seem to have been resolved as well.

And as you can see here it's portal issue.

AbrarSL commented 9 months ago

Could this be reopened? The portal issue has been resolved and apps like Amberol and Celluloid now accept folders.

nlogozzo commented 9 months ago

Could this be reopened? The portal issue has been resolved and apps like Amberol and Celluloid now accept folders.

The code for DnD still exists in the app. So once the flatpak runtime is updated it should just start working again so no need to reopen.

AbrarSL commented 9 months ago

Those other apps use the same or older runtime though. Also from what I can tell Tagger doesn't have a drop target?

Screenshot from 2023-11-26 17-52-16

nlogozzo commented 9 months ago

Those other apps use the same or older runtime though. Also from what I can tell Tagger doesn't have a drop target?

Drop target is there: https://github.com/NickvisionApps/Tagger/blob/main/NickvisionTagger.GNOME/Views/MainWindow.cs#L561

What happens when you drag in a folder? Any error message from the terminal?

AbrarSL commented 9 months ago

It doesn't react to the drop or output any error relevant to it. The only thing printed in the terminal is (org.nickvision.tagger:2): Adwaita-WARNING **: 18:04:25.408: AdwApplicationWindow 0x562d6cc42280 does not have a minimum height, set the 'height-request' property to specify it

Edit: For clarity this is where I'm dropping it Screenshot from 2023-11-26 18-07-30

nlogozzo commented 9 months ago

Ok i will do some more investigating...